Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 271569 - media-gfx/gtkam-0.1.16.1: missing menu icon, bad .desktop entry
Summary: media-gfx/gtkam-0.1.16.1: missing menu icon, bad .desktop entry
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://forums.gentoo.org/viewtopic-t-...
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2009-05-28 18:47 UTC by nm (RETIRED)
Modified: 2009-07-09 22:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gtkam.desktop.patch (gtkam.desktop.patch,543 bytes, patch)
2009-06-24 06:32 UTC, nm (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nm (RETIRED) gentoo-dev 2009-05-28 18:47:47 UTC
Ran across the above URL, and checked it out on my system: sure enough, I no longer have an icon in my desktop menu for gtkam-0.1.16.1. It's not in any submenu.

So I ran qlist gtkam, and it shows that the icons and .desktop entry should be present in the usual places:

$ qlist gtkam
[snip]
/usr/share/applications/gtkam.desktop
/usr/share/pixmaps/gtkam.png
/usr/share/pixmaps/gtkam-camera.png

So I investigated the .desktop file: it's almost completely invalid! It still looks for "gtkam-camera.png", which it's not allowed to do. You're not supposed to use file extensions in your .desktop entries.

I ran the desktop file validation tool just to see what else is wrong:

$ desktop-file-validate /usr/share/applications/gtkam.desktop
warning: key "Encoding" in group "Desktop Entry" is deprecated
error: file contains key "_Name" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
error: file contains key "_Comment" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
warning: value "gtkam-camera.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
error: required key "Name" in group "Desktop Entry" is not present

* * *

This needs a quick fix for Gentoo users, and probably a permanent upstream fix too. As it is, no one who has gtkam installed can actually use their program without resorting to the commandline!

Thanks.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-06-08 22:41:14 UTC
@nightmorph, if you want to fix it, you can go ahead.
Comment 2 nm (RETIRED) gentoo-dev 2009-06-09 03:42:12 UTC
(In reply to comment #1)
> @nightmorph, if you want to fix it, you can go ahead.

I don't have commit access to gentoo-x86; my perms are in other trees, so I need one of you to do it.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-06-23 12:13:57 UTC
hum I thought I commented that patches will obviously be considered if you can't commit it yourself.
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-06-23 12:14:16 UTC
actually adding the keyword sounds sensible.
Comment 5 nm (RETIRED) gentoo-dev 2009-06-24 06:32:19 UTC
Created attachment 195630 [details, diff]
gtkam.desktop.patch

Fixes the errors reported by desktop-file-validate.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-06-24 08:25:05 UTC
looks fine, let's get this merged
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-07-09 22:12:37 UTC
+  09 Jul 2009; Gilles Dartiguelongue <eva@gentoo.org> -gtkam-0.1.14.ebuild,
+  -gtkam-0.1.15.ebuild, gtkam-0.1.16.1.ebuild,
+  +files/gtkam-0.1.16.1-desktop-validation.patch, -files/gtkam.png:
+  Fix validity of .desktop file, bug #271569. Clean up old revisions.
+