Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 269906 - repoman metadata.xml validation doesn't match documented behaviour
Summary: repoman metadata.xml validation doesn't match documented behaviour
Status: RESOLVED OBSOLETE
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-15 05:21 UTC by Ryan Hill (RETIRED)
Modified: 2017-03-16 00:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hill (RETIRED) gentoo-dev 2009-05-15 05:21:32 UTC
I'm not really sure who to assign this to - either repoman isn't following the docs, or the docs are wrong.

Both the Herds project page [1] and the Developer Handbook [2] say:

<pkgmetadata> This is the root element of the metadata.xml file for packages. It has no attributes. Its required subtag is: <herd>. Furthermore, the following subtags are allowed: <email> for a general herd email address, <maintainer>, <longdescription>, <use>, and <upstream>.

But the repoman validation fails when <email> is a subtag of <pkgmetadata>.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
<pkgmetadata>
  <herd>theology</herd>
  <email>theology@gentoo.org</email>
</pkgmetadata>

RepoMan scours the neighborhood...                                                                                                          
!!! metadata.xml is invalid:                                                                                                                
!!! I/O error : Attempt to load network entity http://www.gentoo.org/dtd/metadata.dtd                                                       
!!! /home/dirtyepic/cvs/gentoo-x86/app-text/sword/metadata.xml:2: warning: failed to load external entity "http://www.gentoo.org/dtd/metadata.dtd"                                                                                                                                      
!!! <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">                                                                  
!!!                                                                       ^                                                                 
!!! /home/dirtyepic/cvs/gentoo-x86/app-text/sword/metadata.xml:3: element pkgmetadata: validity error : Element pkgmetadata content does not follow the DTD, expecting (herd | maintainer | longdescription | use | upstream)*, got (herd email )                                       
!!! Document /home/dirtyepic/cvs/gentoo-x86/app-text/sword/metadata.xml does not validate against /usr/portage/distfiles/metadata.dtd

Wrapping <email> inside <maintainer> works as advertised, but the docs say this is supposed to be used when a package has a different maintainer than the listed herd, not for the general herd address.

[1] http://www.gentoo.org/proj/en/metastructure/herds/index.xml#doc_chap4
[2] http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=4
Comment 1 nm (RETIRED) gentoo-dev 2009-05-15 07:09:12 UTC
CCing the doc maintainers; they can sort out what needs to be changed.
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2009-12-26 09:48:58 UTC
http://archives.gentoo.org/gentoo-dev/msg_3e335b01696e786598c55b6ace346beb.xml

repoman should check the value for <herd> against herds listed in herds.xml
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2009-12-26 09:49:45 UTC
(In reply to comment #2)
> http://archives.gentoo.org/gentoo-dev/msg_3e335b01696e786598c55b6ace346beb.xml
> 
> repoman should check the value for <herd> against herds listed in herds.xml
> 

thought I was in a tab inputting a new bug :(
Comment 4 Zac Medico gentoo-dev 2012-09-09 04:30:03 UTC
(In reply to comment #2)
> http://archives.gentoo.org/gentoo-dev/msg_3e335b01696e786598c55b6ace346beb.
> xml
> 
> repoman should check the value for <herd> against herds listed in herds.xml

We've had a herds check since portage-2.1.9:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=7c11c8ec5f568984ee720fc677959f9d2c9dfd32
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2012-09-09 06:37:30 UTC
That comment was unrelated to this bug.
Comment 6 Brian Dolbec gentoo-dev 2017-03-16 00:21:48 UTC
Is this still a problem with the new split repoman pkg?

Herds are no longer, not sure this is still releveant, closing, re-open if it is.