269225 – [PATCH] repoman should warn about virtuals with non-empty HOMEPAGE or LICENSE

Bug 269225 - [PATCH] repoman should warn about virtuals with non-empty HOMEPAGE or LICENSE

Summary: [PATCH] repoman should warn about virtuals with non-empty HOMEPAGE or LICENSE

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Repoman (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	302803
	Show dependency tree

Reported:	2009-05-10 08:52 UTC by Ulrich Müller
Modified:	2010-01-29 21:33 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add warning for non-empty HOMEPAGE or LICENSE in virtuals (repoman.diff,1.92 KB, patch) 2009-05-10 08:53 UTC, Ulrich Müller	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ulrich Müller gentoo-dev

2009-05-10 08:52:13 UTC

The devmanual says:
,----[ http://devmanual.gentoo.org/general-concepts/virtuals/ ]
| [...] a new-style virtual has an empty string for the value of the
| LICENSE and HOMEPAGE variables. Since it installs no files, it really
| does not have a license.
`----

So I think repoman should warn about it. Patch will follow.

Comment 1 Ulrich Müller gentoo-dev

2009-05-10 08:53:44 UTC

Created attachment 190815 [details, diff]
Add warning for non-empty HOMEPAGE or LICENSE in virtuals

Comment 2 Zac Medico gentoo-dev

2010-01-07 20:20:33 UTC

Thanks, this is in svn r15174.

Comment 3 Zac Medico gentoo-dev

2010-01-29 21:33:52 UTC

This is fixed in 2.1.7.17 and 2.2_rc62.