Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 268442 - sys-power/acpid-1.0.10: strict aliasing warnings
Summary: sys-power/acpid-1.0.10: strict aliasing warnings
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-03 14:39 UTC by Rafał Mużyło
Modified: 2009-05-06 10:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A patch that seems to fix it (alias.patch,2.19 KB, patch)
2009-05-03 14:40 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2009-05-03 14:39:01 UTC
While compiling, standard strict aliasing warning is printed:
"warning: dereferencing pointer ‘ghdr’ does break strict-aliasing rules"
(yes, this is a standard warning - for gcc 4.4 (the ebuild was from hardened overlay, I think) - portage should probably be updated to catch it, 
as it checks only for older wording:
"dereferencing type-punned pointer will break strict-aliasing rules").
I wrote a patch, that I think fixes it, though I'm not sure if it's correct.
Comment 1 Rafał Mużyło 2009-05-03 14:40:50 UTC
Created attachment 190225 [details, diff]
A patch that seems to fix it

This is that patch.
Could somebody tell me if it's correct ?
Comment 2 Peter Alfredsen (RETIRED) gentoo-dev 2009-05-04 05:10:09 UTC
I just sent Ted Felix the patch. If I haven't posted a comment in a fortnight, poke me.
Comment 3 Peter Alfredsen (RETIRED) gentoo-dev 2009-05-05 08:43:33 UTC
Ted accepted the patch -- thanks!

+*acpid-1.0.10_p3 (05 May 2009)
+
+  05 May 2009; Peter Alfredsen <loki_val@gentoo.org>
+  +acpid-1.0.10_p3.ebuild:
+  Bump with patch from Rafał Mużyło <galtgendo@o2.pl>, bug 268442, fixing
+  strict aliasing warnings, accepted upstream.
+

Comment 4 Rafał Mużyło 2009-05-06 10:20:53 UTC
OK, and did portage author receive his little bit ?
I don't want to open a new bug about it,
as gcc 4.4.0 is not in portage yet (bit slow,
4.3.0 at this time after its release was already in tree
and 4.4 is breaking far less - well, at least with
the obvious failures (include related), not sure about
the less trivial ones).
Comment 5 Peter Alfredsen (RETIRED) gentoo-dev 2009-05-06 10:36:56 UTC
(In reply to comment #4)
> OK, and did portage author receive his little bit ?

One task for each bug. Otherwise you'll just make a list next time and CC everyone :-)
CC me and I'll get it assigned ASAP