Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 266875 - net-misc/br2684ctl is too fast
Summary: net-misc/br2684ctl is too fast
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-20 18:31 UTC by Helmut Jarausch
Modified: 2012-07-21 14:01 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for openrc's /lib64/rc/net/br2684ctl.sh (br2684ctl.sh.diff,344 bytes, patch)
2009-04-20 18:32 UTC, Helmut Jarausch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2009-04-20 18:31:13 UTC
Using the ppp network protocol and ATM/Ethernet bridging (br2684ctl)
the network doesn't come up because my new PhenomII is too fast.
It was working just fine on an older PC.
A 'sleep' command in /lib64/rc/net/br2684ctl.sh fixes the problem --- see the
attached patch. (the sleep amount of 30 seconds just works, I haven't tried
to find a minimum value, yet.)

Reproducible: Always




 emerge --info
Portage 2.2_rc31 (default/linux/amd64/2008.0/desktop, gcc-4.3.3, glibc-2.9_p20081201-r2, 2.6.29-gentoo-r1 x86_64)
=================================================================
System uname: Linux-2.6.29-gentoo-r1-x86_64-AMD_Phenom-tm-_II_X4_940_Processor-with-gentoo-2.0.0
Timestamp of tree: Mon, 20 Apr 2009 17:45:01 +0000
ccache version 2.4 [disabled]
app-shells/bash:     4.0_p17-r1
dev-java/java-config: 1.3.7-r1, 2.1.7
dev-lang/python:     2.5.4-r2, 2.6.2
dev-python/pycrypto: 2.0.1-r8
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.6.3-r1
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.3-r2
sys-apps/sandbox:    1.9
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.19.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.28-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-mtune=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg distlocks fixpackages parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo "
LDFLAGS="-Wl,-O1"
LINGUAS="en de"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/portage/layman/java-overlay"
SYNC="rsync://rsync.informatik.RWTH-Aachen.de/gentoo-portage"
USE="3dnow 3dnowext 3dnowprefetch X acl acpi alsa amd64 atm avahi berkdb bluetooth branding bzip2 cairo cdr cli cracklib crypt cups dbus dri dvd dvdr dvdread eds emboss encode esd evo fam ffmpeg fftw firefox fortran gdbm gfortran gif gimp gnome gpm gstreamer gtk gtk2 hal iconv ipv6 isdnlog jpeg kde lapack lcms libnotify mad midi mikmod mmx mmxext mp3 mpeg mudflap multilib ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl png ppds pppd python qt qt3 qt3support qt4 quicktime readline reflection sdl session smp spell spl sqlite sqlite3 sse sse2 sse3 sse4a ssl startup-notification svg sysfs tcl tcpd threads tiff tk truetype unicode usb vorbis xml xorg xulrunner xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en de" USERLAND="GNU" VIDEO_CARDS="radeonhd"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Helmut Jarausch 2009-04-20 18:32:42 UTC
Created attachment 188972 [details, diff]
patch for openrc's /lib64/rc/net/br2684ctl.sh
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-04-22 13:17:55 UTC
assigning to maintainers
Comment 3 Helmut Jarausch 2009-04-22 14:06:27 UTC
(In reply to comment #1)
> Created an attachment (id=188972) [edit]
> patch for openrc's /lib64/rc/net/br2684ctl.sh
> 

Further tests have shown that a 'sleep 1' instead of 'sleep 30'
(as proposed in my previous patch) suffices.
Comment 4 MaratIK 2009-07-30 02:59:58 UTC
I think, this addition to /lib/rc/net/br2684ctl.sh is more reasonable than patch (it checks the interface creation every second)

Instead of "sleep 30" I suggest that:

        local endval="$?" timeout=30 i=0
        while true; do
                if [ -e /dev/${IFACE} ]; then
                        eend ${endval}
                fi
                sleep 1
                [ ${timeout} -eq 0 ] && continue
                i=$((${i} + 1))
                [ ${i} -ge ${timeout} ] && break
        done
        eend ${endval}
Comment 5 William Hubbs gentoo-dev 2009-12-21 06:40:28 UTC
Roy,

is this still an issue with the current openrc?  I looked at the code in
git and do not see where a sleep has been inserted.

If it is still an issue, could this be fixed before the next release?
Comment 6 Roy Marples 2009-12-21 09:21:12 UTC
imo the br2684 program should do this before the parent process returns.
Comment 7 MaratIK 2009-12-21 10:45:35 UTC
Sorry, I can not test it anymore because my old AccessRunner-based ADSL-modem has been died. So I switched to ADSL-router and currently that problem is not for me.
Comment 8 William Hubbs gentoo-dev 2010-01-18 22:58:00 UTC
Net-dialup team,

can someone look into fixing this?  It has been determined that fixing br2684ctl would be a better option than delaying in openrc.

Also, this is a blocker for openrc going stable.
Thanks,

William
Comment 9 William Hubbs gentoo-dev 2010-01-27 20:46:15 UTC
(In reply to comment #8)
> Net-dialup team,
> can someone look into fixing this?  It has been determined that fixing
> br2684ctl would be a better option than delaying in openrc.

What is the status of this bug?  Should we leave this as a blocker?

Thanks,

> William

Comment 10 Peter Volkov (RETIRED) gentoo-dev 2010-01-28 10:07:55 UTC
William, I don't know if this helps you, but... there is linux-atm package which also provides br2684ctl, and since there is no bug opened against it probably it's good idea to suggest use that. At least debian uses br2684ctl from linux-atm in the recent distributions. But well, Alin knows this things better...

BTW, have anybody tried linux-atm with openrc?
Comment 11 MaratIK 2010-01-28 10:14:26 UTC
There is need to change file /usr/share/doc/openrc-0.6.0-r1/net.example
>>>>>>
#-----------------------------------------------------------------------------
# RFC 2684 Bridge Support
# For RFC 2684 bridge support emerge net-misc/br2684ctl
<<<<<<
Comment 12 MaratIK 2010-01-28 10:28:14 UTC
(In reply to comment #10)

> BTW, have anybody tried linux-atm with openrc?
> 

After diffing /var/tmp/portage/net-misc/br2684ctl-20040226/work/br2684ctl-20040226.orig/br2684ctl.c against /var/tmp/portage/net-dialup/linux-atm-2.5.0/work/linux-atm-2.5.0/src/br2684/br2684ctl.c it seems that problem remains. In source from linux-atm there is no checks for real interface creation (I'm not accounting asynchronous call for ioctl which is the same as in net-misc/br2684ctl)
Comment 13 William Hubbs gentoo-dev 2010-01-28 16:09:54 UTC
(In reply to comment #10)
> William, I don't know if this helps you, but... there is linux-atm package
> which also provides br2684ctl, and since there is no bug opened against it
> probably it's good idea to suggest use that. At least debian uses br2684ctl
> from linux-atm in the recent distributions. But well, Alin knows this things
> better...
> BTW, have anybody tried linux-atm with openrc?

I would say that we need to know for sure whether the separate package br2684ctl is deprecated, and if it is, remove it from the tree.  Also, there is a bug requesting aversion bump for linux-atm.  We need to do that and figure out whether that fixes this issue.

Thanks,

William
Comment 14 William Hubbs gentoo-dev 2010-02-01 19:44:58 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > BTW, have anybody tried linux-atm with openrc?
> > 
> After diffing
> /var/tmp/portage/net-misc/br2684ctl-20040226/work/br2684ctl-20040226.orig/br2684ctl.c
> against
> /var/tmp/portage/net-dialup/linux-atm-2.5.0/work/linux-atm-2.5.0/src/br2684/br2684ctl.c
> it seems that problem remains. In source from linux-atm there is no checks for
> real interface creation (I'm not accounting asynchronous call for ioctl which
> is the same as in net-misc/br2684ctl)

Have you actually tested linux-atm with openrc to see if the issue happens?  I'm not on dialup, so there is no  way for me to do that.

Thanks,

William
Comment 15 MaratIK 2010-02-01 19:54:27 UTC
(In reply to comment #14)

> Have you actually tested linux-atm with openrc to see if the issue happens? 
> I'm not on dialup, so there is no  way for me to do that.
> 

No. In comment #7 I wrote that my ADSL-modem has been died. So, I can not check it now.
Comment 16 Doug Goldstein (RETIRED) gentoo-dev 2010-02-02 04:04:48 UTC
You're going to find it harder and harder to find testers. Most DSL providers are moving to the newer DSL technologies as they can transition their customers off to PPPoE (I believe all US providers have moved to PPPoE by now). The configuration used by people in this situation is PPPoA, which I believe you'll have a hard time finding.

I say we remove this as a blocker and fix it when we get a bug report.
Comment 17 MaratIK 2010-02-02 06:17:00 UTC
(In reply to comment #16)
> You're going to find it harder and harder to find testers. Most DSL providers
> are moving to the newer DSL technologies as they can transition their customers
> off to PPPoE (I believe all US providers have moved to PPPoE by now). The
> configuration used by people in this situation is PPPoA, which I believe you'll
> have a hard time finding.

br2684 is used in PPPoE configuration for some USB-modems (Alcatel Speedtouch or Connexant Accessrunner for example) in bridged mode (for establishing ethernet channel over ADSL and then pppd creates PPPoE link on top of that channel). But I think that there are too few people who use that modems, most of them switched to ADSL-routers.
Comment 18 Pacho Ramos gentoo-dev 2012-07-21 14:01:25 UTC
dropped