Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 266031 - [PATCH][gnome-overlay]gnome-extra/gconf-editor-2.26.0 optional PolicyKit support
Summary: [PATCH][gnome-overlay]gnome-extra/gconf-editor-2.26.0 optional PolicyKit support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.26
  Show dependency tree
 
Reported: 2009-04-13 17:50 UTC by Romain Perier (RETIRED)
Modified: 2009-04-15 22:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
the patch which solves the problem (Manisfest included !) (0001-gconf-editor-Fixed-static-PolicyKit-support-and-ad.patch,11.80 KB, patch)
2009-04-13 17:50 UTC, Romain Perier (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Perier (RETIRED) gentoo-dev 2009-04-13 17:50:05 UTC
Hi,

As specified in the overlay TODO it was necessary to make the PolicyKit support optional (it was original static).

You'll find in attachment the patch at git format-patch format which fix the problem and update the ebuild.

The issue was easy :
 - I Added a call to AC_ARG_WITH in the configure.in (the default behavior is preserved to default=yes to avoid problem on an upstream)
 - Only if the support is enable, configure script defines a macroconstant "HAVE_POLICYKIT" in the config.h
 - I Added a call the AM_CONDITIONAL

For the src/Makefile.am only and only if HAVE_POLICYKIT is defined we need to include gconf-policykit module with it interface, otherwise we exclude it.

I also modified src/gconf-editor-window module to make appropriate call to gconf_pk_* only if the support is required, and i fixed some QA warning generated by the patch (see comments)

For the ebuild, i added the "policykit" USE flag, applied the patch and made a call to eautoreconf.

mrpouet


Reproducible: Always
Comment 1 Romain Perier (RETIRED) gentoo-dev 2009-04-13 17:50:57 UTC
Created attachment 188249 [details, diff]
the patch which solves the problem (Manisfest included !)
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-15 21:27:32 UTC
applied without a bump. Thanks for the patch. I'll attach the updated patch to the upstream report.
Comment 3 Romain Perier (RETIRED) gentoo-dev 2009-04-15 22:39:37 UTC
upstream opened, see http://bugzilla.gnome.org/show_bug.cgi?id=579096 ;)