Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 264134 - media-sound/mp3gain-1.4.6-r2 does not respect LDFLAGS
Summary: media-sound/mp3gain-1.4.6-r2 does not respect LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High QA (vote)
Assignee: Tony Vroon
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ldflags
  Show dependency tree
 
Reported: 2009-03-29 02:36 UTC by Joshua Rich
Modified: 2010-08-09 21:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against mp3gain-1.4.2-r2.ebuild (mp3gain-1.4.6-respect-LDFLAGS.patch,839 bytes, patch)
2009-03-29 02:38 UTC, Joshua Rich
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Rich 2009-03-29 02:36:21 UTC
media-sound/mp3gain-1.4.6-r2, current stable on all keyworded archs does not respect LDFLAGS.  A QA warning is generated when compiling:

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/mp3gain

The attached patch fixes this QA issue. Please adjust as necessary!

Thanks and regards,

Joshua Rich

Reproducible: Always
Comment 1 Joshua Rich 2009-03-29 02:38:56 UTC
Created attachment 186616 [details, diff]
patch against mp3gain-1.4.2-r2.ebuild
Comment 2 Joshua Rich 2009-03-29 02:40:51 UTC
(In reply to comment #1)
> Created an attachment (id=186616) [edit]
> patch against mp3gain-1.4.2-r2.ebuild
> 

Apologies, that is a patch against mp3gain-1.4.6-r2.ebuild, my mistake in the version.
Comment 3 Tony Vroon gentoo-dev 2009-04-16 16:38:48 UTC
+*mp3gain-1.4.6-r3 (16 Apr 2009)
+
+  16 Apr 2009; <chainsaw@gentoo.org> -mp3gain-1.4.6-r1.ebuild,
+  +mp3gain-1.4.6-r3.ebuild:
+  Patch by Joshua Rich to respect LDFLAGS, closes bug #264134. Remove old
+  ebuild.

Your contribution to Gentoo Linux is highly appreciated :)