Bug 263990 – [gnome-overlay] www-client/epiphany-2.26.0 fails to compile against xulrunner-1.9.1_beta3

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Auty (RETIRED) 2009-03-27 19:11:33 UTC]

Hiya guys,

Just a quick note to say that compiling epiphany-2.26 against xulrunner-1.9.1_beta3 fails with the following error:

In file included from GlobalHistory.h:41,
                 from MozRegisterComponents.cpp:64:
EphyHistoryListener.h:36: warning: 'EphyHistoryListener' declared with
greater visibility than the type of its field
'EphyHistoryListener::<anonymous>'
EphyHistoryListener.h:36: warning: 'EphyHistoryListener' declared with
greater visibility than its base 'nsSupportsWeakReference'
MozRegisterComponents.cpp:127: error: 'XULAPPINFO_SERVICE_CONTRACTID'
was not declared in this scope
make[4]: *** [libephymozillaembed_la-MozRegisterComponents.lo] Error 1
make[4]: Leaving directory
`/var/tmp/portage/www-client/epiphany-2.26.0/work/epiphany-2.26.0/embed/mozilla'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
`/var/tmp/portage/www-client/epiphany-2.26.0/work/epiphany-2.26.0/embed'
make[2]: *** [all] Error 2
make[2]: Leaving directory
`/var/tmp/portage/www-client/epiphany-2.26.0/work/epiphany-2.26.0/embed'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/www-client/epiphany-2.26.0/work/epiphany-2.26.0'
make: *** [all] Error 2

It used to be a lot worse in 2.25.92, but 2.26.0 seems just to be lacking an include for that one constant.  There's a simple patch that applies it, but I'm not sure whether that will cause problems for older systems (both of my test boxes are running the beta xulrunner).

[Comment 1 Mike Auty (RETIRED) 2009-03-27 19:12:16 UTC]

Created attachment 186470 [details, diff]
epiphany-2.26.0-moz191.patch

[Comment 2 Gilles Dartiguelongue (RETIRED) 2009-03-28 23:38:41 UTC]

fixed without a bump. Thanks for the patch.

[Comment 3 Gilles Dartiguelongue (RETIRED) 2009-03-30 09:02:15 UTC]

meh I thought I closed this already.