Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 263580 - games-board/pokerth-0.7.1 version bump
Summary: games-board/pokerth-0.7.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
: 264712 (view as bug list)
Depends on: 261400
Blocks:
  Show dependency tree
 
Reported: 2009-03-24 09:55 UTC by George .H
Modified: 2010-01-06 16:26 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pokerth-0.6.4.ebuild (pokerth-0.6.4.ebuild,1.21 KB, text/plain)
2009-03-24 09:56 UTC, George .H
Details
pokerth-0.6.4.ebuild (pokerth-0.6.4.ebuild,1.18 KB, text/plain)
2009-03-27 10:03 UTC, George .H
Details
pokerth-0.6.4.ebuild.diff (pokerth-0.6.4.ebuild.diff,969 bytes, text/plain)
2009-03-27 10:04 UTC, George .H
Details
pokerth-0.7.ebuild (pokerth-0.7.ebuild,1.18 KB, text/plain)
2009-05-11 19:25 UTC, George .H
Details
pokerth-0.7.ebuild.diff (pokerth-0.7.ebuild.diff,968 bytes, patch)
2009-05-11 19:26 UTC, George .H
Details | Diff
diff 0.6.3 -> 0.7 (pokerth-0.7.ebuild.patch,1.30 KB, patch)
2009-05-26 21:36 UTC, Davide Pesavento (RETIRED)
Details | Diff
patch for stable pokerth to disable the plastique style by use flag (pokerth-0.6.3.patch,1.09 KB, text/plain)
2009-06-11 14:54 UTC, Malte E.
Details
pokerth-0.7.1.ebuild (pokerth-0.7.1.ebuild,1.43 KB, text/plain)
2009-07-04 02:28 UTC, Mr. Bones. (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description George .H 2009-03-24 09:55:02 UTC
Submitting a slightly modified version of the 0.6.3 ebuild to include the new version of PokerTH. Most internet games require it.

Reproducible: Always

Steps to Reproduce:
Comment 1 George .H 2009-03-24 09:56:10 UTC
Created attachment 186086 [details]
pokerth-0.6.4.ebuild

The new ebuild, practically the same as the old one but had to change the file name slightly.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-24 22:01:47 UTC
Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for our devs.
Comment 3 George .H 2009-03-27 10:03:21 UTC
Created attachment 186400 [details]
pokerth-0.6.4.ebuild

PokerTH v0.6.4 ebuild. It depends on Boost >=1.36.0 (recommended v1.38.0 by the devs at pokerth) Put keywords ~x86 as boost libs >= 1.37 are hard-masked (though if you unmask them the game works ok.)

Playing 0.6.4 with boost 1.35 and below causes intermittent segmentation faults that may take several hours of playing before it occurs.
Comment 4 George .H 2009-03-27 10:04:32 UTC
Created attachment 186401 [details]
pokerth-0.6.4.ebuild.diff

This is a diff between the v0.6.3 ebuild and the v0.6.4 ebuild showing the differences between the 2.
Comment 5 Mr. Bones. (RETIRED) gentoo-dev 2009-03-27 19:26:34 UTC
I'm not planning to add pokerth-0.6.4 until the later boost versions are out of package.mask.
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2009-04-02 22:54:16 UTC
*** Bug 264712 has been marked as a duplicate of this bug. ***
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2009-04-26 11:05:23 UTC
0.7-beta2 was released yesterday.
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2009-05-11 19:02:08 UTC
PokerTH 0.7 final has been released. Btw, boost-1.37 is not masked anymore.
Comment 9 George .H 2009-05-11 19:25:25 UTC
Created attachment 190969 [details]
pokerth-0.7.ebuild

version bump to 0.7 and unmasked boost v1.37.0 lib
Comment 10 George .H 2009-05-11 19:26:13 UTC
Created attachment 190970 [details, diff]
pokerth-0.7.ebuild.diff

This is the diff between the 0.7 and 0.6.3 version.
Comment 11 George .H 2009-05-11 19:27:34 UTC
I been using 0.7 with boost lib 1.37.0 for a while now. I don't sense any problems.
Comment 12 Davide Pesavento (RETIRED) gentoo-dev 2009-05-16 14:43:56 UTC
pokerth_server fails to build here (with boost-1.37.0-r1):

x86_64-pc-linux-gnu-g++ -c -pipe -O2 -march=core2 -ggdb -pipe -Wall -W -D_REENTRANT -DPOKERTH_DEDICATED_SERVER -DENABLE_IPV6 -DPREFIX="/usr" -DQT_NO_DEBUG -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4 -I. -Isrc -Isrc/engine -Isrc/gui -Isrc/gui/qt -Isrc/gui/qt/qttools -Isrc/gui/qt/qttools/nonqthelper -Isrc/net -Isrc/engine/local_engine -Isrc/engine/network_engine -Isrc/config -Isrc/third_party/tinyxml -Isrc/core -Imocs -Iuics -o obj/loghelper_server.o src/core/common/loghelper_server.cpp
x86_64-pc-linux-gnu-gcc -c -pipe -O2 -march=core2 -ggdb -pipe -Wall -W -D_REENTRANT -DPOKERTH_DEDICATED_SERVER -DENABLE_IPV6 -DPREFIX="/usr" -DQT_NO_DEBUG -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4 -I. -Isrc -Isrc/engine -Isrc/gui -Isrc/gui/qt -Isrc/gui/qt/qttools -Isrc/gui/qt/qttools/nonqthelper -Isrc/net -Isrc/engine/local_engine -Isrc/engine/network_engine -Isrc/config -Isrc/third_party/tinyxml -Isrc/core -Imocs -Iuics -o obj/daemon.o src/core/linux/daemon.c
In file included from /usr/include/boost/date_time/local_time/tz_database.hpp:14,
                 from /usr/include/boost/date_time/local_time/local_time.hpp:19,
                 from /usr/include/boost/date_time.hpp:15,
                 from src/core/common/loghelper_server.cpp:32:
/usr/include/boost/date_time/tz_db_base.hpp:161: error: declaration of ‘typedef class boost::date_time::dst_adjustment_offsets<typename time_zone_type::time_duration_type> boost::date_time::tz_db_base<time_zone_type, rule_type>::dst_adjustment_offsets’
/usr/include/boost/date_time/time_zone_base.hpp:76: error: changes meaning of ‘dst_adjustment_offsets’ from ‘class boost::date_time::dst_adjustment_offsets<typename time_zone_type::time_duration_type>’
make[1]: *** [obj/loghelper_server.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Broken boost headers?
Comment 13 George .H 2009-05-22 10:00:35 UTC
(In reply to comment #12)
> pokerth_server fails to build here (with boost-1.37.0-r1):
> 

> 
> Broken boost headers?
> 

The most I can figure out is that the PokerTH devs told me that boost v1.38 is recommended. At least for the standard pokerth install (http://www.pokerth.net/forum?func=view&catid=14&id=2839) You can post a message on their site and see what the problem is with compiling the server.
Comment 14 Gandalf 2009-05-25 20:46:38 UTC
(In reply to comment #12)
> pokerth_server fails to build here (with boost-1.37.0-r1):
> 
> x86_64-pc-linux-gnu-g++ -c -pipe -O2 -march=core2 -ggdb -pipe -Wall -W
> -D_REENTRANT -DPOKERTH_DEDICATED_SERVER -DENABLE_IPV6 -DPREFIX="/usr"
> -DQT_NO_DEBUG -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4 -I.
> -Isrc -Isrc/engine -Isrc/gui -Isrc/gui/qt -Isrc/gui/qt/qttools
> -Isrc/gui/qt/qttools/nonqthelper -Isrc/net -Isrc/engine/local_engine
> -Isrc/engine/network_engine -Isrc/config -Isrc/third_party/tinyxml -Isrc/core
> -Imocs -Iuics -o obj/loghelper_server.o src/core/common/loghelper_server.cpp
> x86_64-pc-linux-gnu-gcc -c -pipe -O2 -march=core2 -ggdb -pipe -Wall -W
> -D_REENTRANT -DPOKERTH_DEDICATED_SERVER -DENABLE_IPV6 -DPREFIX="/usr"
> -DQT_NO_DEBUG -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4 -I.
> -Isrc -Isrc/engine -Isrc/gui -Isrc/gui/qt -Isrc/gui/qt/qttools
> -Isrc/gui/qt/qttools/nonqthelper -Isrc/net -Isrc/engine/local_engine
> -Isrc/engine/network_engine -Isrc/config -Isrc/third_party/tinyxml -Isrc/core
> -Imocs -Iuics -o obj/daemon.o src/core/linux/daemon.c
> In file included from
> /usr/include/boost/date_time/local_time/tz_database.hpp:14,
>                  from
> /usr/include/boost/date_time/local_time/local_time.hpp:19,
>                  from /usr/include/boost/date_time.hpp:15,
>                  from src/core/common/loghelper_server.cpp:32:
> /usr/include/boost/date_time/tz_db_base.hpp:161: error: declaration of
> ‘typedef class boost::date_time::dst_adjustment_offsets<typename
> time_zone_type::time_duration_type>
> boost::date_time::tz_db_base<time_zone_type,
> rule_type>::dst_adjustment_offsets’
> /usr/include/boost/date_time/time_zone_base.hpp:76: error: changes meaning of
> ‘dst_adjustment_offsets’ from ‘class
> boost::date_time::dst_adjustment_offsets<typename
> time_zone_type::time_duration_type>’
> make[1]: *** [obj/loghelper_server.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> 
> Broken boost headers?
> 

It seems so. I had the same problem. This is fixed in 1.38.0 if I understand correctly. If you wanna get it to work with 1.37.0 you have to patch boost and rebuild it.

Edit the file boost/date_time/tz_db_base.hpp as follows:

-      typedef dst_adjustment_offsets<time_duration_type> dst_adjustment_offsets;
+      typedef boost::date_time::dst_adjustment_offsets<time_duration_type> dst_adjustment_offsets; 

I did this and it worked for me.
Comment 15 Davide Pesavento (RETIRED) gentoo-dev 2009-05-26 21:26:52 UTC
The suggested workaround fixes pokerth compilation. Thanks! The broken header is already fixed in boost 1.38 btw.
Comment 16 Davide Pesavento (RETIRED) gentoo-dev 2009-05-26 21:36:15 UTC
Created attachment 192543 [details, diff]
diff 0.6.3 -> 0.7

*) raised boost dep to >= 1.38 (see above)
*) x11-libs/qt-core is always needed as a build-time dep because qmake is used in src_configure(), even with USE=dedicated
Comment 17 Malte E. 2009-06-10 18:57:09 UTC
wouldn't it be nice to disable the forced plastique style optionally by use flag?
I changed this in an ebuild in my overlay:
IUSE="dedicated disable-force-plastique"
pkg-setup:
        if use disable-force-plastique ; then                                                  
                ewarn "You disabled the forced plastique style. This is not"                   
                ewarn "supported by upstream and might lead to artifacts in"                   
                ewarn "the UI. To solve this, recompile with"                                  
                ewarn "USE=- \"disable-force-plastique\"."
        fi

src_prepare:
        if use disable-force-plastique ; then
                sed -i -e 's/a.setStyle(new QPlastiqueStyle);//' pokerth.cpp
        fi

I think the pokerth guys should add an option for this in the settings.
Comment 18 Davide Pesavento (RETIRED) gentoo-dev 2009-06-10 20:17:09 UTC
(In reply to comment #17)
> wouldn't it be nice to disable the forced plastique style optionally by use
> flag?

It'd be really nice. Plastique integrates very badly with kde4.
Comment 19 Malte E. 2009-06-11 14:54:29 UTC
Created attachment 194256 [details]
patch for stable pokerth to disable the plastique style by use flag

with the Plastique style, pokerth integrates even worse when using bespins xbar.
I added a patch for the stable ebuild - I already tried it, it's working. In my first post, the path to the file that has to be changed, is wrong.
apart from the fact that the menu bar space is kept in the main window, I could not find and further artifacts by a quick look over all the different UI parts.
And while we have custom-cxxflags, I see no reason why we should not have disable-force-plastique (or whatever you might want to call that USE-Flag).
Comment 20 Tiago Falcão 2009-06-20 23:14:51 UTC
Please include EBUILD in Keywords
Comment 21 Davide Pesavento (RETIRED) gentoo-dev 2009-06-21 23:55:47 UTC
0.7.1_beta released.
Comment 22 Mr. Bones. (RETIRED) gentoo-dev 2009-07-04 02:28:28 UTC
Created attachment 196567 [details]
pokerth-0.7.1.ebuild
Comment 23 Davide Pesavento (RETIRED) gentoo-dev 2009-07-04 12:14:49 UTC
I don't understand why you depend on boost:1.37, but later append -I and -L flags for boost-1.38 and 1.39... Could you explain the reasons behind that?
Comment 24 George .H 2009-07-04 22:36:25 UTC
I tried building pokerth-0.7.1 but had this error.
I am using boost 1.37 because that's the latest one that comes with portage. I have a feeling that this error can be resolved if I had boost 1.39 ... ?

/usr/include/boost/date_time/tz_db_base.hpp:161: error: declaration of 'typedef class boost::date_time::dst_adjustment_offsets<typename time_zone_type::time_duration_type> boost::date_time::tz_db_base<time_zone_type, rule_type>::dst_adjustment_offsets'
/usr/include/boost/date_time/time_zone_base.hpp:76: error: changes meaning of 'dst_adjustment_offsets' from 'class boost::date_time::dst_adjustment_offsets<typename time_zone_type::time_duration_type>'
make[1]: *** [obj/loghelper_server.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/games-board/pokerth-0.7.1/work/PokerTH-0.7.1-src'
make: *** [sub-pokerth_server-pro-make_default-ordered] Error 2
 * 
 * ERROR: games-board/pokerth-0.7.1 failed.
 * Call stack:
 *               ebuild.sh, line   48:  Called src_compile
 *             environment, line 3308:  Called games_src_compile
 *             environment, line 1807:  Called die
 * The specific snippet of code:
 *           emake || die "emake failed"
 *  The die message:
 *   emake failed
Comment 25 Davide Pesavento (RETIRED) gentoo-dev 2009-07-05 14:24:39 UTC
(In reply to comment #24)

boost-1.37 has a broken boost/date_time/tz_db_base.hpp, already fixed in >= 1.38.
See comment #14 for a workaround.
Comment 26 Davide Pesavento (RETIRED) gentoo-dev 2009-07-18 10:18:29 UTC
This has already been fixed.
Comment 27 Mr. Bones. (RETIRED) gentoo-dev 2009-07-21 02:22:39 UTC
fixed.