Bug 263446 – media-sound/pulseaudio-0.9.14 still requires >=net-wireless/bluez-utils-3

• Status: RESOLVED DUPLICATE of bug 257770
• Product: Gentoo Linux

[Description renato gallo 2009-03-23 06:49:55 UTC]

the api has changed in bluez4 I have noticed that the bluez-utils and bluez-libs are included in the bluez4 package so I tried changing the ebuild making it depend on just net-wireless/bluez and all seems working fine.

Reproducible: Always

Steps to Reproduce:
1.emerge pulseaudio


Actual Results:  
it requires bluez-utils and bluez-libs

Expected Results:  
it compiles with just net-wireless/bluez

[Comment 1 renato gallo 2009-03-23 06:53:24 UTC]

Created attachment 185961 [details]
ebuild with updated bluez4 deps

this ebuild works with bluez4

[Comment 2 renato gallo 2009-03-23 06:55:44 UTC]

Created attachment 185962 [details]
opps errata corrige

THIS IS THE RIGHT ONE

[Comment 3 Lars Wendler (Polynomial-C) (RETIRED) 2009-03-23 20:40:51 UTC]

Please attach diffs when you did changes to an ebuild. That would be much more
handy for our devs.

[Comment 4 renato gallo 2009-03-24 09:27:47 UTC]

diff -c ebuild.correct pulseaudio-0.9.14.ebuild                 
*** ebuild.correct      2009-03-24 10:25:32.000000000 +0100                          
--- pulseaudio-0.9.14.ebuild    2009-02-24 12:36:29.000000000 +0100                  
***************                                                                      
*** 33,39 ****                                                                       
        )                                                                            
        app-admin/eselect-esd                                                        
        bluetooth? (                                                                 
!               net-wireless/bluez                                                   
                >=sys-apps/dbus-1.0.0                                                
        )
        policykit? ( sys-auth/policykit )
--- 33,39 ----
        )
        app-admin/eselect-esd
        bluetooth? (
!               >=net-wireless/bluez-libs-3
                >=sys-apps/dbus-1.0.0
        )
        policykit? ( sys-auth/policykit )
***************
*** 60,66 ****
  RDEPEND="${RDEPEND}
        gnome-extra/gnome-audio
        alsa? ( media-sound/alsa-utils )
!       bluetooth? ( net-wireless/bluez )"

  pkg_setup() {
        enewgroup audio 18 # Just make sure it exists
--- 60,66 ----
  RDEPEND="${RDEPEND}
        gnome-extra/gnome-audio
        alsa? ( media-sound/alsa-utils )
!       bluetooth? ( >=net-wireless/bluez-utils-3 )"

  pkg_setup() {
        enewgroup audio 18 # Just make sure it exists
***************
*** 192,195 ****

        eselect esd update --if-unset
  }
-
--- 192,194 ----


(In reply to comment #3)
> Please attach diffs when you did changes to an ebuild. That would be much more
> handy for our devs.
> 

[Comment 5 renato gallo 2009-03-24 09:34:09 UTC]

*** pulseaudio-0.9.14.ebuild    2009-02-24 12:36:29.000000000 +0100              
--- ebuild.correct      2009-03-24 10:32:48.000000000 +0100                      
***************                                                                  
*** 33,39 ****                                                                   
        )                                                                        
        app-admin/eselect-esd                                                    
        bluetooth? (                                                             
!               >=net-wireless/bluez-libs-3                                      
                >=sys-apps/dbus-1.0.0                                            
        )
        policykit? ( sys-auth/policykit )
--- 33,39 ----
        )
        app-admin/eselect-esd
        bluetooth? (
!               net-wireless/bluez
                >=sys-apps/dbus-1.0.0
        )
        policykit? ( sys-auth/policykit )
***************
*** 60,66 ****
  RDEPEND="${RDEPEND}
        gnome-extra/gnome-audio
        alsa? ( media-sound/alsa-utils )
!       bluetooth? ( >=net-wireless/bluez-utils-3 )"

  pkg_setup() {
        enewgroup audio 18 # Just make sure it exists
--- 60,66 ----
  RDEPEND="${RDEPEND}
        gnome-extra/gnome-audio
        alsa? ( media-sound/alsa-utils )
!       bluetooth? ( net-wireless/bluez )"

  pkg_setup() {
        enewgroup audio 18 # Just make sure it exists
***************
*** 192,194 ****
--- 192,195 ----

        eselect esd update --if-unset
  }
+
(In reply to comment #3)
> Please attach diffs when you did changes to an ebuild. That would be much more
> handy for our devs.
> 

[Comment 6 Mike Auty (RETIRED) 2009-03-29 00:57:33 UTC]

Since it appears that pulseaudio can use either bluez-3 or bluez-4, it's probably best to change the dependencies as follows:

bluetooth? (
   || ( net-wireless/bluez
        ( >=net-wireless/bluez-libs-3
          >=net-wireless/bluez-utils-3 
        )
      )
  )

That also then eliminates the need for the later addition of bluez-utils to the RDEPEND.

Renato, when submitting patches, you might find it more legible to submit "unified" patches, by using the -u flag to diff...  5:)

[Comment 7 renato gallo 2009-03-29 10:18:06 UTC]

sorry I will probably remember next time... it would be usefull to make a gentoo tool to make it automatically.

(In reply to comment #6)
> Since it appears that pulseaudio can use either bluez-3 or bluez-4, it's
> probably best to change the dependencies as follows:
> 
> bluetooth? (
>    || ( net-wireless/bluez
>         ( >=net-wireless/bluez-libs-3
>           >=net-wireless/bluez-utils-3 
>         )
>       )
>   )
> 
> That also then eliminates the need for the later addition of bluez-utils to the
> RDEPEND.
> 
> Renato, when submitting patches, you might find it more legible to submit
> "unified" patches, by using the -u flag to diff...  5:)
> 

[Comment 8 Mike Auty (RETIRED) 2009-04-01 16:55:38 UTC]

Sorry I didn't spot it sooner, this is actually a duplicate of bug 257770...

*** This bug has been marked as a duplicate of bug 257770 ***