Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 262949 - app-admin/conky-1.7.0_rc1 - please rename ibm USE flag
Summary: app-admin/conky-1.7.0_rc1 - please rename ibm USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: David Shakaryan (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-18 18:29 UTC by Henning Schild
Modified: 2009-07-11 09:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henning Schild 2009-03-18 18:29:47 UTC
conky supports accessing smapi battery details for ibm/lenovo and maybe other laptops. The conky developers called that feature "ibm" but it has nothing to do with "global:ibm: Add support for IBM ppc64 specific systems". The feature should be mapped to another USEFLAG which should create a dependency on app-laptop/tp_smapi. Older conky ebuilds use the local flag "smapi". Maybe conky 1.7 enables more than smapi when ibm is set, i did not check.

Reproducible: Always

Steps to Reproduce:
Comment 1 Brenden Matthews 2009-03-19 19:24:26 UTC
The IBM stuff is indeed just smapi things.  I'm not sure why it got changed from smapi to ibm, but I see not reason not to make the use flag 'smapi' instead of 'ibm'.
Comment 2 Sebastian Günther 2009-03-19 23:35:25 UTC
According to the changelog this enables ibm_acpi support as well.
Comment 3 Brenden Matthews 2009-03-20 04:31:47 UTC
(In reply to comment #2)
> According to the changelog this enables ibm_acpi support as well.
> 

True, I didn't check Makefile.am like I should have.

I guess 'smapi' isn't appropriate then.  Suggestions?
Comment 4 Sebastian Günther 2009-03-20 15:57:18 UTC
I know that there are the two local flags ibm_acpi and smapi. I have a thinkpad and until now I only encountered people with a thinkpad, using these.

Does anyone know if these are specific to thinkpads? If so, one could establish a thinkpad use flag.
Comment 5 Ian Stakenvicius (RETIRED) gentoo-dev 2009-04-07 16:45:45 UTC
Given that ibm_acpi has been renamed to thinkpad_acpi in the kernel anyways, I think 'thinkpad' would be appropriate.

The acpi directory is still '/proc/acpi/ibm' though.
Comment 6 Sebastian Günther 2009-04-07 17:14:16 UTC
(In reply to comment #5)
> Given that ibm_acpi has been renamed to thinkpad_acpi in the kernel anyways, I
> think 'thinkpad' would be appropriate.
> 
> The acpi directory is still '/proc/acpi/ibm' though.
> 
Well, such things are called backward compatibility... 
Comment 7 Marc O'Connor 2009-06-26 19:45:52 UTC
Any idea if this will be fixed or changed?
Comment 8 Daniel Pielmeier gentoo-dev 2009-07-11 09:04:31 UTC
Fixed in conky-1.7.1.1.