Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 259596 - cmake-utils does not expose the chosen build directory
Summary: cmake-utils does not expose the chosen build directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks: 259686
  Show dependency tree
 
Reported: 2009-02-19 14:21 UTC by Christoph Gysin
Modified: 2009-03-11 10:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
add CMAKE_BUILD_DIR and simplify eclass (cmake-utils.patch,3.89 KB, text/plain)
2009-02-19 14:23 UTC, Christoph Gysin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Gysin 2009-02-19 14:21:58 UTC
I'm writing an ebuild using cmake-utils eclass and need to know the chosen build directory.

cmake-utils uses ${WORKDIR}/${PN}_build (or ${S} if CMAKE_IN_SOURCE_BUILD is nonzero). I changed the eclass to set a variable CMAKE_BUILD_DIR with the used build dir. This var can now be used by ebuilds.

A nice side effect of that change is that now src_configurein is exactly the same as src_configureout with CMAKE_BUILD_DIR=${S}. This makes src_configurein superfluous. And since src_configure only sets CMAKE_BUILD_DIR and then calls src_configureout, these two functions can be merged as well.

Additionally, all the checks for in- or out-of-source build can now be removed.

Patch follows.
Comment 1 Christoph Gysin 2009-02-19 14:23:15 UTC
Created attachment 182551 [details]
add CMAKE_BUILD_DIR and simplify eclass

please consider applying
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2009-02-20 17:30:08 UTC
Thanks for idea, i did it in kde-testing overlay and in ~week i will add it to the tree (i plan more updates so i need some time to do them :])
(closing as fixed cause i dont want anybody else to mess around cmake-utils since i already did it :])
Comment 3 Christoph Gysin 2009-03-05 15:32:26 UTC
2 weeks are gone and still not in the tree:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/cmake-utils.eclass

Please close the bug again when it's fixed, otherwise dependencies between bugs don't make much sense.
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2009-03-05 15:37:19 UTC
We run into few major bugs in cmake infrastructure that we are refactoring now.
Take look on kde-testing, we are actualy changing the eclass currently every day :(
Sorry for the noise
Comment 5 Tomáš Chvátal (RETIRED) gentoo-dev 2009-03-11 10:22:30 UTC
Ok now it is in the tree :]