Bug 259503 – [x11 overlay] x11-base/x11-drm-99999999 no longer builds with VIDEO_CARDS="nv" because nv.ko has beed removed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Chí-Thanh Christopher Nguyễn 2009-02-18 17:42:57 UTC]

x11-drm-99999999 fails to emerge because nv.ko has been removed from drm, leaving only nouveau.ko

Reproducible: Always

Steps to Reproduce:
1. VIDEO_CARDS="nv" emerge x11-drm

Actual Results:  
Emerge fails because nv.ko is not found.

Expected Results:  
Do not expect nv.ko to be present.

[Comment 1 Chí-Thanh Christopher Nguyễn 2009-02-18 17:44:16 UTC]

Created attachment 182438 [details, diff]
x11-drm-99999999.ebuild.patch

Diff to updated ebuild. I suggest renaming video_cards_nv to video_cards_nouveau for drm, as x11-drivers/xf86-video-nv does not use drm.

[Comment 2 Wormo (RETIRED) 2009-02-18 21:31:57 UTC]

Thanks for the patch, assigning to overlay owners

[Comment 3 Rémi Cardona (RETIRED) 2009-02-19 13:37:23 UTC]

Let's go for a little review, shall we? :)

9 	XDPVER=4

Cruft, remove it.

11 	inherit x-modular git

x-modular already inherits "git", chances are, it'll work out of the box.

13 	EGIT_REPO_URI="git://anongit.freedesktop.org/git/nouveau/${PN}"

See above.

23 	COMMON_DEPEND="|| ( >=x11-base/xorg-server-1.5[dri] >=x11-base/xorg-server-1.5.3 )"

Please dep on xorg-server-1.5.3[!minimal] or whatever the syntax is. Again, the eclass should take care of this.

39 	src_unpack() {

The src_unpack provided by the eclass doesn't work?

Thanks

[Comment 4 Rémi Cardona (RETIRED) 2009-02-19 13:37:58 UTC]

ACK. Looks good to me.

Thanks

[Comment 5 Donnie Berkholz (RETIRED) 2009-02-21 03:57:50 UTC]

(In reply to comment #3)
> 13      EGIT_REPO_URI="git://anongit.freedesktop.org/git/nouveau/${PN}"

This isn't in the main xorg code, so no, it wouldn't be found automatically by the eclass.

[Comment 6 Bryan Stine (RETIRED) 2009-03-20 19:25:13 UTC]

Removed nv and changed VIDEO_CARDS flag to nouveau as you suggested. Thanks.