Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258051 - Wrong path check in app-office/openoffice-3.0.0 ebuild in pkg_postinst
Summary: Wrong path check in app-office/openoffice-3.0.0 ebuild in pkg_postinst
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-07 18:40 UTC by Thomas Sachau
Modified: 2011-07-06 22:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Sachau gentoo-dev 2009-02-07 18:40:08 UTC
soffice.bin exists in /usr/${libdir}/openoffice/program/ instead of /usr/${libdir}/openoffice/basis3.0/program/.

Because of this, the check for pax change fails and is not done.

Additionally, i would suggest to check, if either /sbin/chpax or /sbin/paxctl exists, since chpax is deprecated and paxctl should be used instead where possible. And a suggestion from solar:

<solar> imo scanelf -Xz perms should be used cuz it does paxctl+chpax perms on an ELF.
Comment 1 Andreas Proschofsky (RETIRED) gentoo-dev 2009-03-27 23:12:06 UTC
If you provide a patch to the ebuild for both that would be nice, really don't know anything about the pax-stuff
Comment 2 Andreas Proschofsky (RETIRED) gentoo-dev 2009-04-25 12:00:42 UTC
First part is fixed, about the rest: Please reopen if there is some sort of patch, really don't know a thing about pax...
Comment 3 Thomas Sachau gentoo-dev 2009-04-25 15:21:08 UTC
This shouldnt be hard:

( [[ -x /sbin/chpax ]] || [[ -x /sbin/paxctl ]] ) && [[ -e /usr/$(get_libdir)/openoffice/program/soffice.bin ]] && scanelf  -Xzm /usr/$(get_libdir)/openoffice/program/soffice.bin
Comment 4 Andreas Proschofsky (RETIRED) gentoo-dev 2009-11-25 12:32:54 UTC
This is commited now, thanks and sorry for taking ages, seems I've missed your reply ... :-(
Comment 5 Gordon Malm (RETIRED) gentoo-dev 2009-12-03 07:55:16 UTC
(In reply to comment #3)
> This shouldnt be hard:
> 
> ( [[ -x /sbin/chpax ]] || [[ -x /sbin/paxctl ]] ) && [[ -e
> /usr/$(get_libdir)/openoffice/program/soffice.bin ]] && scanelf  -Xzm
> /usr/$(get_libdir)/openoffice/program/soffice.bin
> 

Is all this really necessary (not positive+haven't checked, really asking)?  Why test for chpax and paxctl but then run scanelf?  Besides, this won't work, it needs to be -Xxzm at minimum.  Why not simply:

scanelf  -qXxzm /usr/$(get_libdir)/openoffice/program/soffice.bin
Comment 6 Thomas Sachau gentoo-dev 2010-04-18 18:43:11 UTC
@openoffice team: Any comment on the suggested simplification from Gordon? Looks ok to me.
Comment 7 Andreas Proschofsky (RETIRED) gentoo-dev 2011-07-06 22:30:13 UTC
pax check has been long changed, so closing