Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 257820 - Ebuild for dev-lang/smlnj-110.67-r2 moves files from distdir
Summary: Ebuild for dev-lang/smlnj-110.67-r2 moves files from distdir
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High QA (vote)
Assignee: Gentoo Team for the ML programming language family
URL:
Whiteboard:
Keywords:
Depends on: 262203
Blocks:
  Show dependency tree
 
Reported: 2009-02-05 21:23 UTC by sg313
Modified: 2009-10-09 14:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sg313 2009-02-05 21:23:02 UTC
Problem:
The ebuild for dev-lang/smlnj-110.67-r2 moves files from $DISTDIR to temporary souce dir. Ebuilds should never modify the $DISTDIR. Some package managers report this as sandbox violations.

Proposed Solution:
Please change the "mv" to "cp" (in src_unpack).

Thanks,
Sigurd

Reproducible: Always
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2009-02-05 22:56:54 UTC
Ew!
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2009-03-09 17:20:30 UTC
The ebuild does actually fail with a permission denied error using portage-2.2_rc23. Please change the severity of this bug.
IMHO the ebuild should be migrated to EAPI 2 and use the new SRC_URI arrows syntax.
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2009-03-09 17:24:14 UTC
Something like:

SRC_URI="amd64? ( ${BASE_URI}boot.x86-unix.tgz -> ${P}-boot.x86-unix.tgz )
        x86? ( ${BASE_URI}boot.x86-unix.tgz -> ${P}-boot.x86-unix.tgz )
        ppc? ( ${BASE_URI}boot.ppc-unix.tgz -> ${P}-boot.ppc-unix.tgz )
        sparc? ( ${BASE_URI}boot.sparc-unix.tgz -> ${P}-boot.sparc-unix.tgz )"

for file in ${FILES}; do
        SRC_URI="${SRC_URI} ${BASE_URI}${file} -> ${P}-${file}"
done
Comment 4 Marijn Schouten (RETIRED) gentoo-dev 2009-03-09 23:39:46 UTC
I have changed the mv to cp, used source arrows (thanks Davide) and to top it off, bumped to 110.69.

Please test it, so I can remove the old versions and close this bug. Thanks for your help.
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2009-03-10 15:17:48 UTC
You should add ~sparc to KEYWORDS because SRC_URI references it. Or drop it from both places...

Furthermore, the following source tarballs are not needed because the corresponding features are disabled by default:
eXene.tgz
ml-burg.tgz
heap2asm.tgz
ckit.tgz
nlffi.tgz
smlnj-c.tgz [not sure about this one]

You may also want to remove the (now obsolete) comment about fetch_files.sh
Thanks!

I'll test the new ebuild as soon as I get home.
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2009-03-10 22:39:55 UTC
110.69 doesn't build on ~amd64 :(

/var/tmp/portage/dev-lang/smlnj-110.69/work/config/unpack: Un-GZIP-ing and un-TAR-ing bootfiles archive.
./config/install.sh: CM metadata directory name is ".cm"
/var/tmp/portage/dev-lang/smlnj-110.69/work/bin/.run/run.x86-linux: Fatal error -- Uncaught exception SysErr with <unknown> raised at <sysconf.c>

./config/install.sh !!! Boot code failed, no heap image (sml.x86-linux).
 *
 * ERROR: dev-lang/smlnj-110.69 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2173:  Called die
 * The specific snippet of code:
 *       SMLNJ_HOME="${S}" ./config/install.sh || die "compilation failed"
 *  The die message:
 *   compilation failed
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/dev-lang/smlnj-110.69/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/dev-lang/smlnj-110.69/temp/environment'.
 *

I also tried 110.68 and 110.67, even outside portage (i.e. manually): neither works...
Comment 7 Marijn Schouten (RETIRED) gentoo-dev 2009-03-10 23:36:50 UTC
(In reply to comment #5)
> You should add ~sparc to KEYWORDS because SRC_URI references it. Or drop it
> from both places...

It is up to the sparc team to add the actual keyword. Having the SRC_URI reference makes it possible for them to do so in the future if they are interested.

> You may also want to remove the (now obsolete) comment about fetch_files.sh

Yes, I'll remove it some time.

(In reply to comment #6)
> 110.69 doesn't build on ~amd64 :(

You ARE running multilib, right? This only runs if you have x86 emulation enabled. I am on ~amd64 myself.

Please open a fresh bug and include full build log and emerge --info.
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2009-03-11 21:46:28 UTC
(In reply to comment #7)
> (In reply to comment #5)
> > You should add ~sparc to KEYWORDS because SRC_URI references it. Or drop it
> > from both places...
> 
> It is up to the sparc team to add the actual keyword. Having the SRC_URI
> reference makes it possible for them to do so in the future if they are
> interested.

Right, sorry.


> You ARE running multilib, right? This only runs if you have x86 emulation
> enabled. I am on ~amd64 myself.

Yes, I'm using the default amd64 2008.0 desktop profile.

> 
> Please open a fresh bug and include full build log and emerge --info.
> 

Done, bug #262203