25465 – net-tools compile error with GCC 3.3

Bug 25465 - net-tools compile error with GCC 3.3

Summary: net-tools compile error with GCC 3.3

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Nicholas Wourms

URL:
Whiteboard:
Keywords:

Depends on:	24270
Blocks:
	Show dependency tree

Reported:	2003-07-28 17:00 UTC by Boyd Waters
Modified:	2004-04-18 22:29 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to x25_sr.c to appease GCC 3.3 (x25_sr-gcc33.patch,430 bytes, patch) 2003-07-28 17:01 UTC, Boyd Waters	Details \| Diff
new patch to x25_sr.c -- ebuild compatible (x25_sr-gcc33.patch,467 bytes, patch) 2003-07-28 17:36 UTC, Boyd Waters	Details \| Diff
patch for new ebuild; 1.60-r7 => r8 (net-tools-1.60-r7-r8.patch,395 bytes, patch) 2003-07-28 17:39 UTC, Boyd Waters	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Boyd Waters 2003-07-28 17:00:30 UTC

GCC 3.3 is more strict (or at least different) with some compiler parsing. 
 
net-tools runs afoul of this in lib/x25_sr.c; where a sizeof(x25_address) is interpreted as 
taking the size of an (undefined) FUNCTION named "x25_address", rather that a STRUCT. 

Reproducible: Always
Steps to Reproduce:
emerge net-utils 
Actual Results:  
compile error at lib/x25_sr.c

Comment 1 Boyd Waters 2003-07-28 17:01:54 UTC

Created attachment 15162 [details, diff]
patch to x25_sr.c to appease GCC 3.3

adds a "struct" keyword to the offending line of C code.

Comment 2 Boyd Waters 2003-07-28 17:36:40 UTC

Created attachment 15163 [details, diff]
new patch to x25_sr.c -- ebuild compatible

patch with full path info, tested for use with new ebuild

Comment 3 Boyd Waters 2003-07-28 17:39:06 UTC

Created attachment 15164 [details, diff]
patch for new ebuild; 1.60-r7 => r8

This ebuild uses the patch to correct the compile error.

Comment 4 Martin Holzer (RETIRED) gentoo-dev

2003-08-28 16:37:14 UTC

also etherwake has now it's own ebuild
should the own ebuild or install in net-tools be removed ?

Comment 5 Alexander Gabert (RETIRED) gentoo-dev

2004-03-05 02:44:32 UTC

can we close this bug or is there something left to do for us here?

thanks,

Alex

Comment 6 SpanKY gentoo-dev

2004-04-18 22:29:12 UTC

etherwake and net-tools both build for me on gcc-3.x so this is a done deal in my eyes