Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 254043 - app-laptop/tp_smapi-0.40 version bump request
Summary: app-laptop/tp_smapi-0.40 version bump request
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Peter Weller (RETIRED)
Keywords: InVCS
Depends on: 219285
  Show dependency tree
Reported: 2009-01-07 08:14 UTC by Anton Bolshakov
Modified: 2009-03-25 20:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Proposed ebuild for tp_smapi-0.40 (tp_smapi-0.40.ebuild,1.30 KB, text/plain)
2009-01-07 23:53 UTC, A Frederick Christensen
tp_smapi-0.40, EAPI2 (tp_smapi-0.40.ebuild,1.21 KB, text/plain)
2009-01-08 01:21 UTC, Anton Bolshakov
tp_smapi-0.40, EAPI2 (tp_smapi-0.40-r2.ebuild,1.56 KB, text/plain)
2009-01-26 12:21 UTC, Anton Bolshakov
tp_smapi-0.40 (tp_smapi-0.40-r3.ebuild,1.35 KB, text/plain)
2009-02-25 10:44 UTC, Anton Bolshakov

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2009-01-07 08:14:56 UTC
0.40 2008-12-16
- thinkpad_ec: Added a "force_io=1" module parameter, to let it load on
  recent ThinkPad models (e.g., T400 and T500). This is a kludge to work
  around an ACPI DSDT which claims the ports we need.
- tp_smapi: Don't restore battery charging thresholds when resuming from
- When building, use /lib/modules/*/build instead of /lib/modules/*/src
  and give a clearer error message if that's missing.
Comment 1 Anton Bolshakov 2009-01-07 08:26:03 UTC
would be nice if you could fix bug #215967 as it is part of that package and uses existing USE flag as an optional switch to install it.

Comment 2 A Frederick Christensen 2009-01-07 23:53:15 UTC
Created attachment 177719 [details]
Proposed ebuild for tp_smapi-0.40

This is modified from the 0.39 ebuild. It compiles and runs properly for me with the hdaps use flag on amd64. I run a T400 that needs the force_io=1 module parameter introduced in 0.40.
Comment 3 Anton Bolshakov 2009-01-08 01:21:20 UTC
Created attachment 177733 [details]
tp_smapi-0.40, EAPI2

Not sure if we still need RESTRICT="userpriv"
It might be also possible to check for CONFIG_DMI* (?) in .config before doing DEPEND. It should not strictly depend on it.
Comment 4 Anton Bolshakov 2009-01-26 12:21:35 UTC
Created attachment 179758 [details]
tp_smapi-0.40, EAPI2 

the patch from bug #219285 applied
Comment 5 Benjamin Schulz 2009-02-24 11:16:25 UTC
I have a 2.6.28 kernel. I installed tp_smapi with USE="hdaps". however, in the
init file /etc/init.d/hdapsd, there were the following lines

    if [[ ! -e /sys/block/${DISK}/queue/protect ]] ; then
        eerror "No protect entry for ${DISK}!"
        eerror "Make sure your kernel is patched with the blk_freeze patch"
        return 1

Obviously, Kernel 2.6.28 doesn't neet that check. In fact, it produces errors
and does not allow, hdapsd to start. hdapsd works on my system, if I start it
with hdapsd -d sda -s 12 -a. It is just that check in /etc/init.d/hdapsd which
does not work. So, I commented the above lines out. Disk-shock protection now
works on my system.
Comment 6 Anton Bolshakov 2009-02-24 13:31:12 UTC
Yes, you already reported in the bug #166166. Please stop spamming.

You should use my overlay, the attach #175470 in the bug above or suggest your own.

Comment 7 Benjamin Schulz 2009-02-25 08:57:00 UTC
This is not intendet as spam. 

The problem is, that I don't know which ebuild installs the file in  


I do not speak of a test in an ebuild file. But of a test in a config file, which prevents the hdapsd daemon to be executed. 

However, I don't know which ebuild does install the /etc/init.d/hdapsd file....
Comment 8 Benjamin Schulz 2009-02-25 09:05:46 UTC
another point: 
Looking at the source-code of tha hdapsd drivers from the Kernel and tp_smapi shows, that they updated the kernel driver somewhat. The Kernel driver now seems to support more thinkpads than the hdaps module from tp_smapi. Although the kernel driver still uses the sys interface. 

Furthermore, even if the hdaps module is loaded before tp_smapi (as suggested in the readme), tp_smapi seems to refuse to work with the new kernel driver.

Since it seems that the hdaps module from kernel supports more thinkpads now, I would suggest, that the hdapsd driver from tp_smapi is updated a bit. At least it should support the same models as the driver from kernel.
Comment 9 Anton Bolshakov 2009-02-25 10:44:37 UTC
Created attachment 183118 [details]

Don't provide udev rule any more. It's provided by app-laptop/hdapsd
Comment 10 Anton Bolshakov 2009-02-25 10:52:07 UTC
(In reply to comment #8)

hdapsd.init file belongs to app-laptop/hdapsd, you can verify it by running:
equery b /etc/init.d/hdapsd

hdaps use flag is optional and allows you to choose which HDAPS module (kernel or tp_smapi's hacked version) to use. I suggest you to contact upstream if have any suggestions on improvement any of them.
And thanks for the note. I have updated ebuilds to make that option clearer.
Comment 11 Patrick McLean gentoo-dev 2009-03-25 20:02:21 UTC
app-laptop/tp_smapi-0.40 is now in the tree with a fix for bug #219285.