Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253119 - =sys-apps/findutils-4.5.3 fails its testsuite
Summary: =sys-apps/findutils-4.5.3 fails its testsuite
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
Depends on:
Reported: 2008-12-30 11:09 UTC by Gilles Dartiguelongue (RETIRED)
Modified: 2009-03-04 19:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

build.log (build.log,119.44 KB, text/plain)
2008-12-30 11:10 UTC, Gilles Dartiguelongue (RETIRED)
Proposed patch (findutils-posixh.patch,975 bytes, patch)
2009-01-19 20:54 UTC, Nick Fortino
Details | Diff
Backported upstream patch (findutils-4.5.3-posixh.patch,666 bytes, patch)
2009-03-04 04:21 UTC, Nick Fortino
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-12-30 11:09:53 UTC
Portage 2.2_rc20 (default/linux/amd64/2008.0, gcc-4.3.2, glibc-2.9_p20081201-r0, 2.6.27-gentoo-r7 x86_64)
System uname: Linux-2.6.27-gentoo-r7-x86_64-AMD_Turion-tm-_64_X2_Mobile_Technology_TL-50-with-glibc2.2.5
Timestamp of tree: Mon, 29 Dec 2008 09:45:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p48
dev-lang/python:     2.5.2-r8
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.6.2
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.0
sys-apps/sandbox:    1.3.2
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.19
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.28
ACCEPT_KEYWORDS="amd64 ~amd64"
CFLAGS="-march=athlon64 -O2 -g -pipe"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2 -g -pipe"
FEATURES="ccache distlocks fixpackages multilib-strict parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict test unmerge-orphans userfetch"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS="fr en ja"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTDIR_OVERLAY="/usr/portage/local/layman/voip /usr/portage/local/layman/sunrise /home/eva/devel/overlay/comwax /home/eva/devel/overlay/gentoo-misc /home/eva/devel/overlay/gnome-live /home/eva/devel/overlay/autotua/overlay"
USE="X a52 aac accessibility acl acpi alsa amd64 asyncns avahi bash-completion bogofilter bzip2 cairo cdr cjk cli consolekit cracklib crypt cups curl daap dbus dga dri dvd dvdr eds encode evo exif ffmpeg flac freewnn galago glitz gnome gnome-keyring gnutls gphoto2 gpm gstreamer gtk gtkhtml hal iconv ipv6 isdnlog jpeg kqemu laptop ldap libgda libnotify logrotate mad mmx mmxext mpeg mudflap multilib musicbrainz nautilus ncurses networkmanager nfs nls nntp nptl nptlonly ntp ogg openct opengl openmp pam pcre pdf perl png ppds pppd pth python readline reflection sasl session smp spell spl sqlite sse sse2 ssl startup-notification subversion svg sysfs tcpd theora threads tracker unicode urandom usb v4l v4l2 vim-syntax vorbis x264 xattr xcb xinerama xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="dav dav_fs authn_file auth_digest authz_groupfile authz_host dir mime" CAMERAS="directory ptp2" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LINGUAS="fr en ja" USERLAND="GNU" VIDEO_CARDS="vesa nv nouveau"
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-12-30 11:10:12 UTC
Created attachment 176859 [details]
Comment 2 Nick Fortino 2009-01-19 20:53:11 UTC
This seems to be fixed by undoing an optimization change made upstream:

Undoing this commit fixes the test failures.
Upstream bug submitted:
Comment 3 Nick Fortino 2009-01-19 20:54:34 UTC
Created attachment 179035 [details, diff]
Proposed patch
Comment 4 Nick Fortino 2009-03-04 04:21:25 UTC
Created attachment 183835 [details, diff]
Backported upstream patch

This has been resolved upstream, see the upstream bug in the above comment for details.

Backported patch attached.
Comment 5 Xake 2009-03-04 05:06:01 UTC
(In reply to comment #4)
> Created an attachment (id=183835) [edit]
> Backported upstream patch
> This has been resolved upstream, see the upstream bug in the above comment for
> details.
> Backported patch attached.

How come your patch is so much shorter then the last patch posted upstream, and also shorter then the one that acctually made it into git [1]?

Also you may consider following Mikes suggestions for patches [2].

Comment 6 Nick Fortino 2009-03-04 05:45:42 UTC
(In reply to comment #5)

The patch is so short because it only changes the code, not the ChangeLog and unit tests. I didn't think it was appropriate to keep around ChangeLog entries which are designed to be in 4.5.4 in a 4.5.3 backport. 
Also, the upstream patch undoes the first pass at fixing the bug, and then applies this patch. Obviously, the 4.5.3 release doesn't have a first pass at fixing the bug, so there is no need to revert it.

As for cleaning patches, I have read that, and usually use it (see my old patch), but I failed this time around :(
Comment 7 SpanKY gentoo-dev 2009-03-04 07:15:11 UTC
thanks, added the patch to 4.5.3-r1
Comment 8 Xake 2009-03-04 19:40:43 UTC
(In reply to comment #6)

Thanks for the information, nice to see you fix it and take it upstream, and thanks vapier for handling it quickly now when a patch was avaible.