Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 252101 - x11-misc/xdialog: pre-stripped files found
Summary: x11-misc/xdialog: pre-stripped files found
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prestripped
  Show dependency tree
 
Reported: 2008-12-21 21:56 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-02-11 10:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to configure.in to remove block that adds '-s' to CFLAGS (xdialog-no-strip.patch,395 bytes, patch)
2009-01-17 18:00 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-21 21:56:20 UTC
x11-misc/xdialog-2.3.1:20081211-104458.log:  * QA Notice: Pre-stripped files found:
x11-misc/xdialog-2.3.1:20081211-104458.log:  * /var/tmp/portage/x11-misc/xdialog-2.3.1/image/usr/bin/Xdialog

Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Thanks,
Diego
Comment 1 Kevin Pyle 2009-01-17 18:00:29 UTC
Created attachment 178803 [details, diff]
Patch to configure.in to remove block that adds '-s' to CFLAGS

The build system contains a check in configure.in that examines CFLAGS and, if -s is not present, adds it.  This patch drops the check and associated assignment.  The ebuild will need to regenerate configure after applying this patch or apply a corresponding patch to configure.  In version 2.3.1, the copy of the CFLAGS check starts at line 8271 in configure.
Comment 2 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-11 10:07:20 UTC
Fixed, I've modified configure.in to recognize only GTK+2 as GTK+1 crap caused errors.