Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 251946 - mail-mta/sendmail: pre-stripped files found
Summary: mail-mta/sendmail: pre-stripped files found
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prestripped
  Show dependency tree
 
Reported: 2008-12-21 20:49 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-08-22 21:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch files/site.config.m4 and sendmail-8.14.2.ebuild to honor $LDFLAGS (sendmail-8.14.2-honor-ldflags.patch,1.19 KB, patch)
2009-01-04 01:17 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-21 20:49:23 UTC
mail-mta/sendmail-8.14.2:20081216-013747.log:  * QA Notice: Pre-stripped files found:
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/makemap
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/mail.local
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/praliases
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/editmap
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/smrsh
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/mailstats
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/sbin/sendmail
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/bin/rmail
mail-mta/sendmail-8.14.2:20081216-013747.log:  * /var/tmp/portage/mail-mta/sendmail-8.14.2/image/usr/bin/vacation

Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Thanks,
Diego
Comment 1 Kevin Pyle 2009-01-04 01:15:15 UTC
This ebuild also ignores user LDFLAGS, though it tends to escape notice since it has hardcoded linking flags of "-Wl,-z,now -s".  The problem is that the build system does not use LDFLAGS directly, but instead the value of the m4 variable confLDOPTS.  Several other conf* m4 variables were already set by the ebuild, but not linker flags.  I will attach a patch that removes the -s and adds the ability for the ebuild to insert user LDFLAGS.  With this change, I get a sendmail that is not prematurely stripped, and which now respects my use of -z,relro.
Comment 2 Kevin Pyle 2009-01-04 01:17:49 UTC
Created attachment 177296 [details, diff]
Patch files/site.config.m4 and sendmail-8.14.2.ebuild to honor $LDFLAGS

Apply this patch to update sendmail-8.14.2.ebuild to recognize a new substitution, @@confLDOPTS@@ and use it to insert user $LDFLAGS and to update files/site.config.m4 to remove the explicit strip and add the substitution mark.  I left the explicit -Wl,-z-now in the m4 file.  Users who want lazy binding can add -Wl,-z,lazy to their $LDFLAGS to override it.
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2009-08-22 21:43:07 UTC
Fixed in 8.14.3-r1.