Bug 249638 – media-libs/libdvdread-4.1.3 produces useless library with --as-needed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Martin Väth 2008-12-02 18:27:49 UTC]

If libdvdread-4.1.3 is compiled with LDFLAGS=-Wl,--as-needed, it will not
export all symbols (perhaps even no symbol is exported, I didn't check).
For example, media-dvd/lsdvd fails afterwards early in the configure phase
due to missing symbols.

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2008-12-02 18:37:29 UTC]

Reassigning to media-video herd.

[Comment 2 Yang Zhao 2008-12-17 18:35:47 UTC]

Related upstream discussion and patch here: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2008-October/000880.html

[Comment 3 Lars Wendler (Polynomial-C) (RETIRED) 2008-12-19 21:09:05 UTC]

I've applied the patch mentioned in that mail. Works like a charm on an --as-needed enabled system.

[Comment 4 Lars Wendler (Polynomial-C) (RETIRED) 2009-03-06 01:30:36 UTC]

Created attachment 184080 [details, diff]
libdvdread-4.1.3-as-needed-fix.patch

Maybe attaching the patch helps to get this bug finally fixed :)

[Comment 5 Yang Zhao 2009-03-06 07:48:58 UTC]

Alternatively, simply using autotools instead of configure2 resolves the issue as well.

[Comment 6 Steve Dibb (RETIRED) 2009-03-09 17:39:27 UTC]

(In reply to comment #5)
> Alternatively, simply using autotools instead of configure2 resolves the issue
> as well.
> 

Last I checked (which, admittedly, was quite a while) autotools was totally borked on forked libdvdnav/read.

But, the snapshot in the tree is outdated anyway, so let's push a new one and take it from there.

[Comment 7 Yang Zhao 2009-03-09 17:44:27 UTC]

I've been using an autotools libdvdread overlay, and have not noticed any issues with mplayer or vobcopy. vobcopy was what I initially had issues when I started discussing it upstream.

Overlay at http://yangman.ca/git/gentoo-overlay/ and layman definition at http://yangman.ca/gentoo-overlays.xml

[Comment 8 Steve Dibb (RETIRED) 2009-03-09 18:06:31 UTC]

(In reply to comment #7)
> I've been using an autotools libdvdread overlay, and have not noticed any
> issues with mplayer or vobcopy. vobcopy was what I initially had issues when I
> started discussing it upstream.
> 
> Overlay at http://yangman.ca/git/gentoo-overlay/ and layman definition at
> http://yangman.ca/gentoo-overlays.xml
> 

Awesome, Ill take a look.

Looks like you killed the forced MAKEOPTS as well, I'd like to drop the -j1 if I could.  Working for you, then?

[Comment 9 Yang Zhao 2009-03-09 18:12:01 UTC]

(In reply to comment #8)
> Looks like you killed the forced MAKEOPTS as well, I'd like to drop the -j1 if
> I could.  Working for you, then?

Yup.

[Comment 10 Yang Zhao 2009-03-09 18:14:20 UTC]

The one thing I haven't tried is building it with USE=-css so that needs to be verified.

[Comment 11 Steve Dibb (RETIRED) 2009-03-09 19:01:43 UTC]

(In reply to comment #10)
> The one thing I haven't tried is building it with USE=-css so that needs to be
> verified.
> 

Yah, I already tested that, it's fine.

Alright, switched the new ebuilds (4.1.3_p1168 and -9999) for both libdvdread and libdvdnav to use autotools.

Thanks for the help, Yang, I wasn't doing mine correctly.

[Comment 12 Samuli Suominen (RETIRED) 2009-12-19 22:12:08 UTC]

Closing, since 4.1.3_p1168 is in ~arch and not masked anymore. Also, 4.1.3-r1 was never stable.