Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 248142 - net-misc/sambasentinel: fails with forced --as-needed
Summary: net-misc/sambasentinel: fails with forced --as-needed
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's SAMBA Team
Depends on:
Blocks: as-needed
  Show dependency tree
Reported: 2008-11-22 11:27 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-09-09 12:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Build log (sambasentinel-0.1:20081122-023756.log,31.59 KB, text/plain)
2008-11-22 11:27 UTC, Diego Elio Pettenò (RETIRED)
Patch to address numerous QA issues in upstream Makefile (sambasentinel.patch,687 bytes, patch)
2009-02-13 05:15 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-22 11:27:26 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out for details).

Check the attached build log.

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-22 11:27:36 UTC
Created attachment 172825 [details]
Build log
Comment 2 Kevin Pyle 2009-02-13 05:15:21 UTC
Created attachment 181833 [details, diff]
Patch to address numerous QA issues in upstream Makefile

The upstream Makefile has several QA violations.  In addition to the --as-needed problem reported above, it does not use user CFLAGS when compiling source files or use user LDFLAGS when linking object files, and it always calls gcc by explicit short name, which will interfere with cross-compiling.

This patch corrects those issues by removing the explicit rules, renaming LIBS to LDLIBS to match the variable used by the implicit GNU make rule, and changing the assignment of INCDIR into an append to CFLAGS.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-02 12:56:38 UTC
Thanks Kevin, but I think this might be easier to just drop.

Treecleaners, this package still uses gtk 1.2 (and has broken deps); it was added in 2003, never version bumped; a number of minor cleanups.
Comment 4 Kevin Pyle 2009-06-02 15:10:34 UTC
Fine by me.  I only posted the patch because this bug was attached to bug #129413.  I do not use this package.  Based on the lack of activity in bug #240286, I doubt many other people use it either.  The issue raised there has been unfixed since October 2008 and no one seems to be complaining.
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-07-11 03:28:35 UTC
Diego, I saw that you were taking care of the masking here in another bug. We will let you manage that and remove treecleaners from this bug. thx
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-09-09 12:14:27 UTC