Bug 247982 – texlive-core-2008-r4: remove "deprecated char* conversion" warnings from xpdf library

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Vladimir Rapatskiy 2008-11-21 16:14:03 UTC]

This is a patch to change "char *" into "const char *" where possible in xpdf source subdirectory, to remove gcc 4.3 warnings about deprecated string to char* conversions.

Reproducible: Always

Steps to Reproduce:
1. emerge =app-text/texlive-core-2008-r4 &>emerge.log
2. grep deprecated emerge.log

Actual Results:  
You'll see bunch of warning messages about string to char* conversions in libs/xpdf sources

Expected Results:  
Compilation must not give any warning message

[Comment 1 Vladimir Rapatskiy 2008-11-21 16:15:47 UTC]

Created attachment 172704 [details, diff]
Patch to eliminate xpdf deprecated char* coversion warnings

[Comment 2 Vladimir Rapatskiy 2008-11-21 16:16:45 UTC]

Created attachment 172705 [details]
emerge --info output result

[Comment 3 Vladimir Rapatskiy 2008-11-21 17:25:12 UTC]

Created attachment 172725 [details, diff]
Patch to eliminate xpdf deprecated char* coversion warnings

[Comment 4 Santiago M. Mola (RETIRED) 2008-11-23 19:26:11 UTC]

Vladimir, could you send this patch upstream?

[Comment 5 Vladimir Rapatskiy 2008-11-24 18:40:40 UTC]

(In reply to comment #4)
> Vladimir, could you send this patch upstream?

You mean texlive or xpdf devellopers?
I'll try to send to texlive, cause xpdf looks like abandoned project

[Comment 6 Alexis Ballier 2008-11-29 15:20:00 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > Vladimir, could you send this patch upstream?
> 
> You mean texlive or xpdf devellopers?
> I'll try to send to texlive, cause xpdf looks like abandoned project

I'd say just send the same mail to both of them, just in case

patch applied, thanks

just a small note: if it doesn't get applied upstream and the patch fails to apply in later version i'll probably drop it without warning because it's huge and doesn't harm usability.