Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 247909 - media-video/nvclock: fails with --as-needed
Summary: media-video/nvclock: fails with --as-needed
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at if you want to take care of it
: 264651 (view as bug list)
Depends on:
Blocks: as-needed
  Show dependency tree
Reported: 2008-11-21 11:39 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-04-04 00:17 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Build log (media-video:nvclock-0.8_beta2:20081121-053035.log,7.29 KB, text/plain)
2008-11-21 11:39 UTC, Diego Elio Pettenò (RETIRED)
nvclock-0.8_beta4-as-needed.patch (nvclock-0.8_beta4-as-needed.patch,651 bytes, patch)
2009-04-03 00:26 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-21 11:39:12 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out for details).

Check the attached build log.

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-21 11:39:45 UTC
Created attachment 172657 [details]
Build log
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2009-04-02 06:06:16 UTC
Maybe it's failing because it ignores LDFLAGS completely. I might have fixed this through bug #240846. Please check if media-video/nvclock-0.8_beta4-r1 still fails in this respect.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-04-02 22:56:23 UTC
*** Bug 264651 has been marked as a duplicate of this bug. ***
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-04-03 00:26:56 UTC
Created attachment 187149 [details, diff]

Patch to change link order and fix building with --as-needed.
Comment 5 Xake 2009-04-03 13:18:19 UTC
Since nvclock-0.8_beta4-r2 this is always true since the Makefiles does pick up LDFLAGS.

So could someone please update the summary and/or check in a fix?
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-04-03 13:21:01 UTC
Patch looks good.
Comment 7 Xake 2009-04-03 13:25:26 UTC
Should we even consider go upstream with our changes (i.e. makeing the buildsystem pick up {C,LD}FLAGS and this fix)?
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2009-04-03 23:55:59 UTC
Patch applied media-video/nvclock-0.8_beta4-r3.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2009-04-04 00:17:31 UTC
Mail with both patches attached sent upstream.