Bug 247292 – media-libs/xine-lib-1.1.15 does not build with ImageMagick 6.4.5

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Eric Bosch 2008-11-18 00:57:53 UTC]

make[2]: Entering directory `/var/tmp/portage/media-libs/xine-lib-1.1.15-r1/work/xine-lib-1.1.15/src/libxinevdec'
/bin/sh ../../libtool --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../include -I../.. -I../../include -I../../include -I../../src -I../../src/xine-engine -I../../src/xine-engine -I../../src/xine-utils  -I../../src/input -I../../src/input  -I../../lib -I../../lib   -fvisibility=hidden -fopenmp -I/usr/include/ImageMagick   -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE   -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Werror-implicit-function-declaration -Wstrict-aliasing=2 -march=nocona -O2 -pipe -ggdb -frename-registers -ffunction-sections -DNDEBUG -c -o xineplug_decode_image_la-image.lo `test -f 'image.c' || echo './'`image.c
/bin/sh ../../libtool --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../include -I../.. -I../../include -I../../include -I../../src -I../../src/xine-engine -I../../src/xine-engine -I../../src/xine-utils  -I../../src/input -I../../src/input  -I../../lib -I../../lib   -fvisibility=hidden -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE   -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Werror-implicit-function-declaration -Wstrict-aliasing=2 -march=nocona -O2 -pipe -ggdb -frename-registers -ffunction-sections -DNDEBUG -c -o xineplug_decode_gdk_pixbuf_la-gdkpixbuf.lo `test -f 'gdkpixbuf.c' || echo './'`gdkpixbuf.c
/bin/sh ../../libtool --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../include -I../.. -I../../include -I../../include -I../../src -I../../src/xine-engine -I../../src/xine-engine -I../../src/xine-utils  -I../../src/input -I../../src/input  -I../../lib -I../../lib   -fvisibility=hidden   -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE   -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Werror-implicit-function-declaration -Wstrict-aliasing=2 -march=nocona -O2 -pipe -ggdb -frename-registers -ffunction-sections -DNDEBUG -c -o xineplug_decode_theora_la-xine_theora_decoder.lo `test -f 'xine_theora_decoder.c' || echo './'`xine_theora_decoder.c
mkdir .libs
 x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../include -I../.. -I../../include -I../../include -I../../src -I../../src/xine-engine -I../../src/xine-engine -I../../src/xine-utils -I../../src/input -I../../src/input -I../../lib -I../../lib -fvisibility=hidden -fopenmp -I/usr/include/ImageMagick -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Werror-implicit-function-declaration -Wstrict-aliasing=2 -march=nocona -O2 -pipe -ggdb -frename-registers -ffunction-sections -DNDEBUG -c image.c  -fPIC -DPIC -o .libs/xineplug_decode_image_la-image.o
 x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../include -I../.. -I../../include -I../../include -I../../src -I../../src/xine-engine -I../../src/xine-engine -I../../src/xine-utils -I../../src/input -I../../src/input -I../../lib -I../../lib -fvisibility=hidden -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Werror-implicit-function-declaration -Wstrict-aliasing=2 -march=nocona -O2 -pipe -ggdb -frename-registers -ffunction-sections -DNDEBUG -c gdkpixbuf.c  -fPIC -DPIC -o .libs/xineplug_decode_gdk_pixbuf_la-gdkpixbuf.o
In file included from ../../src/xine-engine/xine_internal.h:33,
                 from image.c:47:
../../include/xine.h:2230: warning: 'xine_tvsystem' is deprecated
image.c: In function 'image_decode_data':
image.c:113: error: implicit declaration of function 'MagickGetImagePixels'
make[2]: *** [xineplug_decode_image_la-image.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from ../../src/xine-engine/xine_internal.h:33,
                 from gdkpixbuf.c:38:
../../include/xine.h:2230: warning: 'xine_tvsystem' is deprecated
 x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../include -I../.. -I../../include -I../../include -I../../src -I../../src/xine-engine -I../../src/xine-engine -I../../src/xine-utils -I../../src/input -I../../src/input -I../../lib -I../../lib -fvisibility=hidden -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Werror-implicit-function-declaration -Wstrict-aliasing=2 -march=nocona -O2 -pipe -ggdb -frename-registers -ffunction-sections -DNDEBUG -c xine_theora_decoder.c  -fPIC -DPIC -o .libs/xineplug_decode_theora_la-xine_theora_decoder.o
In file included from ../../src/xine-engine/xine_internal.h:33,
                 from xine_theora_decoder.c:42:
../../include/xine.h:2230: warning: 'xine_tvsystem' is deprecated
make[2]: Leaving directory `/var/tmp/portage/media-libs/xine-lib-1.1.15-r1/work/xine-lib-1.1.15/src/libxinevdec'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-libs/xine-lib-1.1.15-r1/work/xine-lib-1.1.15/src'
make: *** [all-recursive] Error 1
---------------------------------------------------------------
emerge info:
saruman xine-lib-1.1.15 # emerge --info
Portage 2.2_rc14 (default/linux/amd64/2008.0/desktop, gcc-4.3.2, glibc-2.8_p20080602-r0, 2.6.27-gentoo-r3 x86_64)
=================================================================
System uname: Linux-2.6.27-gentoo-r3-x86_64-Intel-R-_Core-TM-2_CPU_6600_@_2.40GHz-with-glibc2.2.5
Timestamp of tree: Mon, 17 Nov 2008 23:07:02 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.5.2-r8
dev-util/cmake:      2.6.2
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.3.0-r1
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.19
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -O2 -pipe -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=nocona -O2 -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distlocks fixpackages nostrip parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LDFLAGS="-Wl,-O1"
LINGUAS="en en_GB"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/sunrise /usr/local/portage/layman/wschlich /usr/local/portage/layman/gcc-porting /usr/local/portage/layman/pro-audio /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X Xaw3d a52 aac aalib acl acpi alsa amarok amd64 amd64-multilib apache2 arts auth avi berkdb binfilter bitmap-fonts bluetooth bootsplash branding bzip2 cairo cdda cddb cdio cdparanoia cdr cgi clamav cli cpudetection cracklib crypt css ctype cups curl curlwrappers cvs dba dbus dga doc dpms dri dts dv dvb dvd dvdr dvdread eds emboss encode esd ethereal evo examples exif fam fame fbcondecor ffmpeg fftw firefox flac font-server fontconfig foomaticdb fortran galago gd gdbm gif gimp gimpprint git gnome gpm graphviz grub gstreamer gtk gvim gzip hal hash iconv icq ieee1394 imagemagick imlib ipod iptv irmc isdnlog ithreads ivtv jack jackmidi java javascript jfs jpeg kde lame libg++ libnotify libvisual lirc live lm_sensors logrotate loop-aes lpr mad midi mikmod mjpeg mmx mmxext mono mp3 mp3lame mp4 mp4live mpeg mpeg2 mplayer mpm-worker mudflap multilib multislot mysql mythtv ncurses network nfs njb nls nptl nptlonly nsplugin nvidia oav odbc offensive ogg opengl openmp openntpd oss pam pan pcre pda pdf pdflib perl perlsuid php png posix povray ppds pppd profile pulseaudio python qt3 qt3support qt4 quicktime raw readline reflection rtc samba scanner sdk sdl seamonkey sensord server session slp smp snmp source spell spl sqlite sse sse2 ssl startup-notification subversion svg symlink sysfs sysvipc tcl tcpd tetex theora threads tiff tk tools truetype unicode usb utempter utils v4l v4l2 vim vim-syntax visualization vorbis webdav wma wmf wxwindows xcomposite xfs xine xinerama xml xmlreader xmlwriter xorg xprint xulrunner xv zlib" ALSA_CARDS="emu10k1" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_GB" LIRC_DEVICES="hauppauge" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Eric Bosch 2008-11-18 01:24:11 UTC]

After downgrading to media-gfx/imagemagick-6.4.0.6 from 6.4.5.7, Xine-lib was again able to build and install.

[Comment 2 Jean-Francis Roy 2008-11-18 23:13:01 UTC]

Same problem here, same work-around.

Portage 2.2_rc14 (default/linux/amd64/2008.0/desktop, gcc-4.3.2, glibc-2.8_p20080602-r0, 2.6.27-gentoo-r2 x86_64)
=================================================================
System uname: Linux-2.6.27-gentoo-r2-x86_64-Intel-R-_Core-TM-2_CPU_T5600_@_1.83GHz-with-glibc2.2.5
Timestamp of tree: Tue, 18 Nov 2008 16:30:01 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.5.2-r8
dev-util/cmake:      2.6.2
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.3.0-r1
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.19
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/4.1/env /usr/kde/4.1/share/config /usr/kde/4.1/shutdown /usr/kde/4.2/env /usr/kde/4.2/share/config /usr/kde/4.2/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y"
FEATURES="distlocks parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="en_CA"
LC_ALL="en_CA"
LDFLAGS="-Wl,-O1"
LINGUAS="en"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/java-overlay /usr/local/portage/layman/kde-crazy /usr/local/portage/layman/gnome /usr/local/portage/local-overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 avahi bash-completion berkdb bluetooth branding bzip2 cairo cdr cli cracklib crypt cups dbus dri dvd dvdr dvdread eds emboss encode esd evo fam fbcondecor ffmpeg flac fortran fuse gcj gdbm gif gnome gpm gstreamer gtk hal iconv imagemagick ipod ipv6 isdnlog jack jpeg kde kde4 kdeprefix lame laptop ldap libnotify lm_sensors mad midi mikmod mmx mp3 mp4 mpeg mudflap multilib ncurses networkmanager nls nptl nptlonly ntfs nvidia ogg opengl openmp pam pcre pdf perl plasma png ppds pppd python qt3support qt4 quicktime readline reflection reiserfs sdl semantic-desktop session spell spl sse sse2 ssl startup-notification svg sysfs tcpd tiff truetype unicode usb vim-syntax vorbis wifi xcomposite xml xorg xulrunner xv xvid xvmc zeroconf zip zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 3 Michelangelo Scopelliti 2008-11-20 08:34:08 UTC]

I've reported this bug upstreams. I've tried also imagemagick-6.4.4.6-r1, ant it builds fine.

besides, could it be possible to change this bug name in something like

xine-lib-1.15-r1 does not build against =imagemagick-6.4.5.7* ?

[Comment 4 Jeroen Roovers (RETIRED) 2008-11-20 16:24:49 UTC]

(In reply to comment #3)
> I've reported this bug upstreams. I've tried also imagemagick-6.4.4.6-r1, ant
> it builds fine.
> 
> besides, could it be possible to change this bug name in something like
> 
> xine-lib-1.15-r1 does not build against =imagemagick-6.4.5.7* ?

You could have done that all along, but it's better to be more specific (use the actual error message) because it's entirely possible to have two cases where package A doesn't build against package B-<version>.

Just one question - does *rebuilding* =imagemagick-6.4.5.7* solve the issue? There have been a few cases in the past where imagemagick needed to be built and installed twice to properly work.

I.e.:
emerge =imagemagick-6.4.5.7* \
&& emerge =imagemagick-6.4.5.7* \
&& emerge =xine-lib-1.15-r1

[Comment 5 Kristian 2008-11-20 18:49:13 UTC]

(In reply to comment #4)
> Just one question - does *rebuilding* =imagemagick-6.4.5.7* solve the issue?
> There have been a few cases in the past where imagemagick needed to be built
> and installed twice to properly work.

unfortunately not, same error.

image.c: In function `image_decode_data':
image.c:113: error: implicit declaration of function `MagickGetImagePixels'
make[2]: *** [xineplug_decode_image_la-image.lo] Error 1

[Comment 6 Eric Bosch 2008-11-20 20:17:19 UTC]

I was able to build xine-lib against imagemagick-6.4.4.6-r1, but not against 6.4.5.7-r1, so somewhere between those versions it broke.  Possible fix by adding dependency to xine-lib for imagemagick <= 6.4.5*, until xine-lib is updated.

[Comment 7 Paúl Andrés Jiménez 2008-11-21 22:13:04 UTC]

It seems the newest version of ImageMagick replaced MagickGetImagePixels by MagickGetAuthenticPixels (that was the closest match I found). The problem here is that what used to be the return value of the old method is now a new parameter that has to be preallocated in the new method.

Installing 6.4.4.* will have to do in the meanwhile.

[Comment 8 Diego Elio Pettenò (RETIRED) 2008-11-23 16:43:09 UTC]

I've updated the ebuild to depend on the older version.

I hate libraries that change their API in an incompatible way in a POINT RELEASE.... but you have to live with them I guess. In the mean time disable the imagemagick USE flag, it _should_ be disabled by default (it's listed with a starting - in the IUSE line, I did it myself with the intention of most users NOT hitting imagemagick; CCing dev-portage so Zac can check that the behaviour is the one intended).

Oh and this is upstream bug #177.

[Comment 9 Zac Medico 2008-11-23 19:18:55 UTC]

(In reply to comment #8)
> the imagemagick USE flag, it _should_ be disabled by default (it's listed with
> a starting - in the IUSE line, I did it myself with the intention of most users
> NOT hitting imagemagick; CCing dev-portage so Zac can check that the behaviour
> is the one intended).

It is the intended behavior. Disabling flags in IUSE has no effect unless the users as set a non-default USE_ORDER (documented in make.conf man page). The default USE_ORDER is intentionally set this way because both the profile settings and user's local settings are intended to override the IUSE default settings.

[Comment 10 Christer Ekholm 2008-11-24 01:47:39 UTC]

A slot conflict just happened to me.

!!! Multiple package instances within a single package slot have been pulled
!!! into the dependency graph, resulting in a slot conflict:

media-gfx/imagemagick:0

  ('ebuild', '/', 'media-gfx/imagemagick-6.4.4.6-r1', 'merge') pulled in by
    ('installed', '/', 'media-libs/xine-lib-1.1.15-r1', 'nomerge')

  ('ebuild', '/', 'media-gfx/imagemagick-6.4.5.7-r1', 'merge') pulled in by
    ('installed', '/', 'gnome-extra/libgsf-1.14.10', 'nomerge')
    ('installed', '/', 'app-office/openoffice-3.0.0', 'nomerge')


Is this related to this bug?
How can I resolve this?

[Comment 11 Zac Medico 2008-11-24 01:59:34 UTC]

(In reply to comment #10)
>   ('ebuild', '/', 'media-gfx/imagemagick-6.4.5.7-r1', 'merge') pulled in by
>     ('installed', '/', 'gnome-extra/libgsf-1.14.10', 'nomerge')
>     ('installed', '/', 'app-office/openoffice-3.0.0', 'nomerge')

Both of these packages can use the older version, so you can simply mask the new version like this:

  echo >=media-gfx/imagemagick-6.4.5 >> /etc/portage/package.mask

Alternatively, you can disable the imagemagick USE flag for xine-lib and then rebuild it:

  echo media-libs/xine-lib -imagemagick >> /etc/portage/package.use
  emerge -1 media-libs/xine-lib

[Comment 12 Zac Medico 2008-11-24 02:01:25 UTC]

(In reply to comment #11)
>   echo >=media-gfx/imagemagick-6.4.5 >> /etc/portage/package.mask

Actually, you need to quote that atom to avoid interaction with the shell, so use this instead:

  echo '>=media-gfx/imagemagick-6.4.5' >> /etc/portage/package.mask

[Comment 13 Christer Ekholm 2008-11-24 02:05:47 UTC]

Thanks.

I discovered that the only package I had installed with imagemagick use-flag was xine-lib.  So I just disabled it globally in make.conf  I guess I don't need imagemagick

[Comment 14 Robin Johnson 2008-11-27 03:03:01 UTC]

Created attachment 173546 [details, diff]
xine-lib-1.1.15-MagickGetImagePixels.patc

Upstream function MagickGetImagePixels renamed to MagickGetAuthenticPixels.
Please apply and unrestrict imagemagick versions again. Either this patch or the alternative one.

[Comment 15 Robin Johnson 2008-11-27 03:05:03 UTC]

Created attachment 173547 [details, diff]
xine-lib-1.1.15-GetImagePixels-alt.patch

Alternative version of patch. Suitable for upstream trunk. Remember to bump your dep on what version of ImageMagick to at least 6.4.5.4. (I don't see ImageMagick version checks in your autotooling).

[Comment 16 Diego Elio Pettenò (RETIRED) 2008-11-27 19:30:45 UTC]

Attachment #173546 [details, diff] has been queued upstream for applying, media-video feel free to apply.

[Comment 17 Zac Medico 2008-12-05 10:04:07 UTC]

*** Bug 249901 has been marked as a duplicate of this bug. ***

[Comment 18 Jeroen Roovers (RETIRED) 2008-12-18 16:03:22 UTC]

*** Bug 251294 has been marked as a duplicate of this bug. ***

[Comment 19 Peter Volkov (RETIRED) 2008-12-19 11:46:25 UTC]

media-video, it's about 3 weeks since we have solution attached to this patch. Could you apply it or give me Ok to do that. Thanks.

[Comment 20 Alexis Ballier 2008-12-19 13:06:08 UTC]

(In reply to comment #16)
> Attachment #173546 [details, diff] [edit] has been queued upstream for applying, media-video feel free
> to apply.
> 

applied, thanks all

[Comment 21 renato gallo 2009-01-04 11:27:47 UTC]

Created attachment 177324 [details]
ERROR: media-libs/xine-lib-1.1.15-r1 failed

it still fails to compile

[Comment 22 renato gallo 2009-01-04 12:00:12 UTC]

Portage 2.1.6.4 (default/linux/amd64/2008.0, gcc-4.3.2, glibc-2.9_p20081201-r1, 2.6.28 x86_64)
=================================================================
System uname: Linux-2.6.28-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q6600_@_2.40GHz-with-glibc2.2.5
Timestamp of tree: Sun, 04 Jan 2009 10:45:01 +0000
app-shells/bash:     3.2_p48
dev-java/java-config: 1.3.7-r1, 2.1.6-r1
dev-lang/python:     2.4.4-r13, 2.5.2-r8
dev-python/pycrypto: 2.0.1-r6
dev-util/cmake:      2.6.2
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.1-r1
sys-apps/sandbox:    1.3.2
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.19
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.28-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=nocona -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="C"
LDFLAGS="-Wl,-O1"
LINGUAS="it en"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="2dnow 3dnowext 7zip X Xaw3d a52 aac aalib accessibility acl acpi ada addbookmarks akode alias alsa amd64 amr amrb applet aqua_theme ares arts artswrappersuid artworkextra athena autoipd automount autoreplace avahi bash-completion beagle belagle berkdb bidi bl bluetooth bookmarks branding bzip2 cairo carbone_theme cdda cddb cdio cdparanoia cdr cisco cjk clamavfontconfig cli connectionstatus contactnotes cpudetection cracklib crypt cscope cups cupsddk curl dbus debug device-mapper dga directfb disk-partition diskio djvu dmx dnd doc dri dts dv dvb dvd dvdr dvi eds elf emacs emacx enca encode eolconv epiphany esd exif expat extensible fam fasttrack fax fbcon fbcondecor ffmpeg filepicker firefox flac fltk foomaticdb fortran freetts freewnn ftp gadu galago gd gdbm gedit ggi gif gimp glib glitz gnokii gnome gnome-keyring gnomecd gnutella gnutls gphoto2 gpm graphwiz groupwise gsf gstreamer gtk gtkhtml guile gz gzip-el hal hdri hesiod hfs highlight history hotplug howl-compat hybrid-auth iceweasel iconv ieee1394 imagemagick imlib iproute2 ipv6 irc irda irmc isdnlog jack jadetex jai java java5 javamail javascript jbig jce jingle jmf jms jmx joystick jpeg jpeg2k kde kdrive kerberos ladspa lame laptop latex lcms ldap legacyssl libcaca libnotify libsamplerate lirc live lm_sensors logitech-mouse lua lzma lzo mad mbrola md5sum mdnsresponder-compat mfd-rewrites midi mmap mmx mng mono motif mozdevelop mp2 mp3 mpeg mudflap mule multilib musepack mysql mythtv nas nautilus ncurses neXt nemesi netmeeting network networking networkmanager new-login nls nntp nowlistening npp nptl nptlonly nsplugin odbc odk offensive ogg openal openexr openft opengl openmp opensslcrypt oracle pam passwordsave pch pcre pda pdf perl php pkcs11 png pnm pop povray ppds pppd pulseaudio python q32 q8 qt3 qt4 quicktime radio rar rdesktop readline reflection remote resolvconf rpm rtc ruby samba sametime sasl savedconfig scanner schedule script sdl seamonkey sendmail session slang slp smp sms smux snmp socks5 sound speex spell spl srt sse sse2 ssl ssse3 startup-notification statistics suid svg swat sysfs syslog t1lib tcl tcpd teletext test tetex texteffect tga theora tiff tk toolkit-scroll-bars tools tracker translator truetype tseng unicode usb v4l v4l2 vcd vim-pager vim-syntax vim-with-x vorbis wavpack webpresence wifi winpopup wmf x264 xanim xattr xcb xcomposite xemacs xext xface xforms xft xim xine xinerama xinetd xml xorg xprint xscreensaver xulrunner xv xvid xvmc yahoo zeroconf zlib zoran zvbi" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="adc65 agfa_cl20 aox barbie canon casio_qv clicksmart310 digigr8 digita dimagev dimera3500 directory enigma13 fuji gsmart300 hp215 iclick jamcam jd11 kodak_dc120 kodak_dc210 kodak_dc240 kodak_dc3200 kodak_ez200 konica konica_qm150 largan lg_gsm mars mustek panasonic_coolshot panasonic_dc1000 panasonic_dc1580 panasonic_l859 pccam300 pccam600 polaroid_pdc320 polaroid_pdc640 polaroid_pdc700 ptp2 ricoh ricoh_g3 samsung sierra sipix_blink sipix_blink2 sipix_web2 smal sonix sony_dscf1 sony_dscf55 soundvision spca50x sq905 stv0674 stv0680 sx330z template toshiba_pdrm11" DVB_CARDS="tda1004x" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse acecad aiptek digitaledge elographics fpit hyperpen jamstudio joystick magellan mutouch palmax spaceorb summa synaptics tek4957 ur98 vmmouse void wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="it en" LIRC_DEVICES="mceusb2 mceusb devinput" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY

[Comment 23 Martin von Gagern 2009-01-05 16:37:18 UTC]

(In reply to comment #21)
> it still fails to compile

Please change the condition for the workaround from "#if MagickLibVersion >= 0x645" to "#if MagickLibVersion == 0x645", as xine-lib compiles against media-gfx/imagemagick-6.4.8.3 without this fix, but not with the fix.

[Comment 24 Jeroen Roovers (RETIRED) 2009-01-05 16:44:20 UTC]

*** Bug 253691 has been marked as a duplicate of this bug. ***

[Comment 25 Jeroen Roovers (RETIRED) 2009-01-05 16:44:43 UTC]

(In reply to comment #24)
> *** Bug 253691 has been marked as a duplicate of this bug. ***

Why didn't you reopen this bug report?

[Comment 26 renato gallo 2009-01-05 17:39:04 UTC]

(In reply to comment #25)
> (In reply to comment #24)
> > *** Bug 253691 has been marked as a duplicate of this bug. ***
> 
> Why didn't you reopen this bug report?
> 

because the site is telling me I am not entitled to reopen

[Comment 27 Martin von Gagern 2009-01-05 17:53:46 UTC]

(In reply to comment #23)
> (In reply to comment #21)
> > it still fails to compile
> 
> Please change the condition for the workaround from "#if MagickLibVersion >=
> 0x645" to "#if MagickLibVersion == 0x645", as xine-lib compiles against
> media-gfx/imagemagick-6.4.8.3 without this fix, but not with the fix.

I just tracked down the addition of MagickGetImagePixels to deprecate.c:
http://trac.imagemagick.org/changeset/13306/ImageMagick/trunk/wand/deprecate.c
Revision 13306 lies somewhere between the 6.4.5 and the 6.4.6 branch, so only the 6.4.5 line should be affected, and 6.4.6 should be all right, if ever we were to have an ebuild for that series. Thus MagickLibVersion == 0x645 for the workaround is in fact correct, and no range required. The workaround might, however, alias MagickExportImagePixels instead of MagickGetAuthenticPixels, as that's the way upstream implemented things.

[Comment 28 renato gallo 2009-01-05 18:21:10 UTC]

in other words what should I diff to patch ?



(In reply to comment #27)
> (In reply to comment #23)
> > (In reply to comment #21)
> > > it still fails to compile
> > 
> > Please change the condition for the workaround from "#if MagickLibVersion >=
> > 0x645" to "#if MagickLibVersion == 0x645", as xine-lib compiles against
> > media-gfx/imagemagick-6.4.8.3 without this fix, but not with the fix.
> 
> I just tracked down the addition of MagickGetImagePixels to deprecate.c:
> http://trac.imagemagick.org/changeset/13306/ImageMagick/trunk/wand/deprecate.c
> Revision 13306 lies somewhere between the 6.4.5 and the 6.4.6 branch, so only
> the 6.4.5 line should be affected, and 6.4.6 should be all right, if ever we
> were to have an ebuild for that series. Thus MagickLibVersion == 0x645 for the
> workaround is in fact correct, and no range required. The workaround might,
> however, alias MagickExportImagePixels instead of MagickGetAuthenticPixels, as
> that's the way upstream implemented things.
> 

[Comment 29 Martin von Gagern 2009-01-05 18:28:06 UTC]

(In reply to comment #28)
> in other words what should I diff to patch ?

sed -i 's/>=/==/'                                                           \
/usr/portage/media-libs/xine-lib/files/xine-lib-1.1.15-GetImagePixels.patch \
&& ebuild /usr/portage/media-libs/xine-lib/xine-lib-1.1.15-r1.ebuild digest \
&& emerge -1 xine-lib

But be a bit more patient, comments here are mostly for fixing the issue in portage itself, and I assume developers there understand them this way. For instructions about how to locally fix packages where fixes haven't been integrated into portage itself, the forums or IRC might be a better place.

[Comment 30 Alexis Ballier 2009-01-16 22:36:39 UTC]

it seems imagemagick people broke the api then reverted back to the old one... anyway, it works fine here with xine-lib-1.1.16 and imagemagick-6.4.8.3

[Comment 31 Alex Efros 2009-04-01 20:02:04 UTC]

Please fix ebuild for media-libs/xine-lib-1.1.15-r1 in portage (tune imagemagick versions which use GetImagePixels.patch or drop that patch from ebuild at all because it prevent xine-lib to compile with current media-gfx/imagemagick-6.4.8.3).

Also please don't remove 1.1.15 from portage until bug 264539 will be solved in latests xine-lib.