Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 246860 - app-backup/kdar: fails with forced --as-needed
Summary: app-backup/kdar: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: MATSUU Takuto (RETIRED)
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-11-15 13:48 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-02-22 17:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (app-backup:kdar-2.1.0:20081114-192613.log,14.17 KB, text/plain)
2008-11-15 13:49 UTC, Diego Elio Pettenò (RETIRED)
Details
config.log (kdar-2.1.0-config.log,126.28 KB, text/plain)
2008-11-15 13:49 UTC, Diego Elio Pettenò (RETIRED)
Details
Patch for configure.in.in to work with --as-needed (kdar-as-needed.patch,1.85 KB, patch)
2009-02-14 02:20 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-15 13:48:56 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-15 13:49:12 UTC
Created attachment 171808 [details]
Build log
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-15 13:49:25 UTC
Created attachment 171809 [details]
config.log
Comment 3 Kevin Pyle 2009-02-14 02:20:12 UTC
Created attachment 181944 [details, diff]
Patch for configure.in.in to work with --as-needed

I am not a KDE user, so I cannot compile test this patch, but it should lead the way.  I initially patched configure.in.in, but it seems that configure.in may not be regenerated from configure.in.in, so you may need to rebase this patch onto configure.in.  It applies correctly, albeit with some line offsets.

The original problem, which this patch corrects, is that LDFLAGS was used to pass the libraries that the script test programs were meant to detect.  This patch moves the library to LIBS, which configure scripts specify later in the link line.  This also simplifies logic, since a successful link can simply leave the -ldar in $LIBS, and an unsuccessful link is fatal.
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2009-02-22 17:00:11 UTC
Thanks Kevin, applied to kdar-2.1.0-r1.