Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 245927 - Resume broken by gentoo-sources 2.6.26-r2
Summary: Resume broken by gentoo-sources 2.6.26-r2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 245638
  Show dependency tree
 
Reported: 2008-11-07 06:57 UTC by Olivier Crete (RETIRED)
Modified: 2008-12-05 16:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
revert the bad commit (and a dependency) (revert.patch,4.28 KB, text/plain)
2008-11-18 00:02 UTC, Daniel Drake (RETIRED)
Details
revert patch (introduced in 2.6.25.17-18) that breaks resume (revert_resume_break_2.6.25.17-18.patch,2.62 KB, patch)
2008-12-05 16:37 UTC, Robert A.
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Crete (RETIRED) gentoo-dev 2008-11-07 06:57:24 UTC
On my Thinkpad x60s, with 2.6.26-r2, when I resume after sleeping, I can't unblank (sometimes, maybe 1/10 times). It worked perfectly with -r1. I'm investigating the matter further).

More details at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504167

I guess worst case we can make a -r3 without the .6 patches.
Comment 1 Daniel Drake (RETIRED) gentoo-dev 2008-11-07 19:18:37 UTC
Can you please do a bisection of  git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6-stable.git ?

The individual 2.6.26.x releases are tagged, which you can use as bisection points.

Ask in #gentoo-kernel if you need help. Thanks!
Comment 2 Olivier Crete (RETIRED) gentoo-dev 2008-11-08 00:58:38 UTC
I did that in a plane.. 

The offending commit is
7f0a673a75d3f9f50a64f83055b71be67526efd7 clockevents: prevent multiple init/shutdown

My guess is that it exposes another problem, that its not really broken
    
Also see upstream bug  http://bugzilla.kernel.org/show_bug.cgi?id=11978
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2008-11-18 00:02:49 UTC
Created attachment 172143 [details]
revert the bad commit (and a dependency)

OK, given the lack of response upstream, let's just revert the bad parts. Please apply this patch to 2.6.26-r2 and confirm that the problem goes away.
Comment 4 Olivier Crete (RETIRED) gentoo-dev 2008-11-19 03:20:17 UTC
With this patch, it resumes like a charm!
Comment 5 Daniel Drake (RETIRED) gentoo-dev 2008-11-19 22:48:37 UTC
Fixed in genpatches-2.6.26-4 / gentoo-sources-2.6.26-r3, thanks for feedback and testing
Comment 6 Olivier Crete (RETIRED) gentoo-dev 2008-11-22 02:36:40 UTC
Arg, I'm still getting the resume problem with -r3 ....

Maybe we should review the whole serie of clockevent patches ? I'll try and come back to you...
Comment 7 Olivier Crete (RETIRED) gentoo-dev 2008-11-22 02:47:37 UTC
Arg, seems like I was a bit too quick here.. It also break with -r1, so its a different problem.. most likely with the newer intel X drivers...
Comment 8 Robert A. 2008-12-05 15:49:57 UTC
jfyi:
i experience (probably) the same problem on my x60s using 2.6.25 kernel series.
i currently use gentoo-sources-2.6.25-r8 with 2.6.25.20 and reverted patch-2.6.25.17-18 because it breaks resuming on this box.

(In reply to comment #7)
> Arg, seems like I was a bit too quick here.. It also break with -r1, so its a
> different problem.. most likely with the newer intel X drivers...

x11-drivers/xf86-video-intel-2.5.1 works for me (so did xf86-video-i810-2.1.1 before).

Comment 9 Olivier Crete (RETIRED) gentoo-dev 2008-12-05 16:24:24 UTC
My X problem is a deadlock in the kernel's DRM code with a recent X/intel drivers. I haven't taken the time to investigate it yet.
Comment 10 Robert A. 2008-12-05 16:37:57 UTC
Created attachment 174330 [details, diff]
revert patch (introduced in 2.6.25.17-18) that breaks resume

this works for me with gentoo-sources-2.6.25-r9 and 2.6.25.20.