Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 244048 - dev-util/xmlindent: CC variable not respected
Summary: dev-util/xmlindent: CC variable not respected
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Development Tools Team
Depends on:
Blocks: tc-directly
  Show dependency tree
Reported: 2008-10-24 19:18 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-05-07 00:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Patch to xmlindent-0.2.17.ebuild to fix several QA issues (xmlindent.ebuild.patch,998 bytes, patch)
2009-02-14 04:43 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-24 19:18:20 UTC
I'm filing this bug (from a template, mind you) because the ebuild I'm reporting it against failed to build once I removed my /usr/bin/{gcc,cc,c++,c99} binaries. This means that the ebuild is relying on gcc or cc as compiler, while it should use "$(tc-getCC)" so that user choices are respected, and cross-compiling works as intended.

This usually comes down to one of these tasks:

- use emake CC="$(tc-getCC)" for building, to ovewrite make's CC variable (defaults to "cc", some upstream rewrites it);
- the above plus replacing explicit "gcc" (or similar) calls with $(CC) so that the variable is actually respected;
- tc-export CC in src_compile before eventual econf.

For C++, you'd have to replace CC with CXX everywhere above, of course.

If your package is a special case on this, please let me know.

Comment 1 Kevin Pyle 2009-02-14 04:43:18 UTC
Created attachment 181956 [details, diff]
Patch to xmlindent-0.2.17.ebuild to fix several QA issues

The upstream Makefile ignored CC, CFLAGS, and LDFLAGS because it used a rule which called gcc explicitly and did not refer to either flags variable.  This patch modifies the ebuild to export CC as Diego suggested and to add a sed expression which fixes those issues, plus an incorrect dependency rule.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-05-07 00:39:11 UTC
Fixed in -r1.