Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24264 - patches to make a2ps Japanese compatible
Summary: patches to make a2ps Japanese compatible
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-10 22:54 UTC by Georgi Georgiev
Modified: 2003-12-15 17:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
a2ps-japanese.diff (a2ps-japanese.diff,1.31 KB, patch)
2003-07-10 22:55 UTC, Georgi Georgiev
Details | Diff
a2ps-stdout.diff (a2ps-stdout.diff,462 bytes, patch)
2003-07-10 22:56 UTC, Georgi Georgiev
Details | Diff
Output of 'emerge a2ps' with +cjk (emerge_a2ps.txt,22.39 KB, text/plain)
2003-08-11 13:10 UTC, Henk de Leeuw
Details
Output of 'emerge info' with +cjk (emerge_info.txt,1.45 KB, text/plain)
2003-08-11 13:11 UTC, Henk de Leeuw
Details
Output of 'emerge -pv a2ps' with +cjk (emerge_pv_a2ps.txt,194 bytes, text/plain)
2003-08-11 13:12 UTC, Henk de Leeuw
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Georgi Georgiev 2003-07-10 22:54:08 UTC
Suggesting the following patch to the a2ps ebuild to make it print Japanese text
as well.

I also include a patch to make a2ps send to stdout by default. For the reasoning
behind it see:

http://mail.gnu.org/archive/html/bug-a2ps/2001-05/msg00000.html

Of course, I cannot make the devs apply this stdout patch, that I so much desire ;)
Comment 1 Georgi Georgiev 2003-07-10 22:55:29 UTC
Created attachment 14363 [details, diff]
a2ps-japanese.diff

Adds a Japanese patch to a2ps if cjk is in USE
Comment 2 Georgi Georgiev 2003-07-10 22:56:53 UTC
Created attachment 14364 [details, diff]
a2ps-stdout.diff

A file that should go in app-text/a2ps/files/

It makes a2ps print to stdout by default. See
http://mail.gnu.org/archive/html/bug-a2ps/2001-05/msg00000.html for details
why.
Comment 3 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-07-15 14:35:17 UTC
Thanks. These two patches are now in CVS. I added >=sys-apps/sed-4 to DEPEND since not all sed has -i option and Japanese README. Please make sure to add >=sys-apps/sed-4 when you use sed with -i option.  Btw, do you know how to stop ./configure saying an error? Japanese support patch rewrites Makefile.in and configure.in so if cjk is enabled ./configure tries to recreate  configure script and so on but it fails because the author of a2ps seems to use a hacked version of autoconf.  It can be compiled even though it complains about the error, but I'm not so happy with the error message ;( 
Comment 4 Georgi Georgiev 2003-07-15 19:32:06 UTC
So that's why I see lots of "cp file file.old; sed < file.old > file" in ebuilds. It may be better to change the ebuild to use two files for sed-ing and change the sed dependency back to the more liberal one.

About the autoconf problem -- way out of my expertise.
Comment 5 Henk de Leeuw 2003-08-07 01:00:27 UTC
The new ebuild with Japanese support (4.13b-r5) fails to build on my system. I  have cjk support in my USE flags although I don't need it directly.
I've reverted back to 4.13b-r4.
I can do some tests if you want, after I finish my emerge --emptytree (which is what brought the problem to light). So, for me the status of the ebuild is NOT 'Resolved, Fixed'.
Comment 6 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-08-07 07:40:53 UTC
Okay, what does your emerge log say?  I've tested the ebuild on both stable and unstable x86 with combinations of +/-nls, +/-tetex, +/-cjk, but it never failed to emerge.  I guess there might be a problem with autoconf/automake.  Please post the output of emerge a2ps, emerge info and emerge -pv a2ps. 
Comment 7 Henk de Leeuw 2003-08-11 12:51:39 UTC
It seems to be a problem with automake / autoconf indeed, but it only occurs when I have cjk support on. When it is off, there is no problem.
By googling on 'AC_CHECK_MEMBERS a2ps' I found that this location in configure has been a problem in the past, but I cannot see what's wrong as I don't have any experience with autoconf

I will add the outputs of the commands you requested to the Attachments list.

Comment 8 Henk de Leeuw 2003-08-11 13:10:52 UTC
Created attachment 15927 [details]
Output of 'emerge a2ps' with +cjk
Comment 9 Henk de Leeuw 2003-08-11 13:11:33 UTC
Created attachment 15928 [details]
Output of 'emerge info' with +cjk
Comment 10 Henk de Leeuw 2003-08-11 13:12:16 UTC
Created attachment 15929 [details]
Output of 'emerge -pv a2ps' with +cjk
Comment 11 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-08-12 00:06:13 UTC
Thanks.  After all, I think a2ps should be rewritten to use more
recent autoconf.  For the moment I added a patch to not run
autoconf, so please emerge sync and try it.
Comment 12 Georgi Georgiev 2003-12-14 20:18:00 UTC
I spotted a typo in my attachment #14363 [details, diff] that made its way in a2ps-4.13b-r5.ebuild and a2ps-4.13c.ebuild
The "xpatch $PATCHES | die" line should not have a pipe (`|'), but an "or" (`||')

I hope it is OK to simply reopen this bug and not file a separate one.
Comment 13 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-12-15 08:29:13 UTC
I corrected that when I committed the patch but I didn't write it explicitly in bugzilla.
(Sorry if you haven't noticed it) Do you have any problem other than that? 
Comment 14 Georgi Georgiev 2003-12-15 17:30:21 UTC
I don't believe me... What was it called when you start seeing stuff that's not there?