Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 240165 - x11-terms/rxvt-unicode urgency hint patch
Summary: x11-terms/rxvt-unicode urgency hint patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: René Nussbaumer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-05 22:28 UTC by Pierre Guinoiseau
Modified: 2008-11-01 09:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rxvt-unicode-no-urgency-if-focused.diff (rxvt-unicode-no-urgency-if-focused.diff,314 bytes, patch)
2008-10-05 22:29 UTC, Pierre Guinoiseau
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Guinoiseau 2008-10-05 22:28:28 UTC
Hi,

there is a small bug with urgency hint in rxvt-unicode: it sets it even when the window is focused, which is inconsistant, and cause an unneeded notification by the WM.

It can be tested by enabling this in .Xdefaults:
URxvt.urgentOnBell: true
and make a beep :)

The following (trivial) patch correct this.
Comment 1 Pierre Guinoiseau 2008-10-05 22:29:02 UTC
Created attachment 167395 [details, diff]
rxvt-unicode-no-urgency-if-focused.diff
Comment 2 Pierre Guinoiseau 2008-10-05 22:33:00 UTC
Forgot to say that the very bad side of this bug is that you need to unfocus and focus again the window to make the urgency hint disappear, which is very boring.
Comment 3 Wormo (RETIRED) gentoo-dev 2008-10-06 00:58:53 UTC
Thanks for the patch! Which version of x11-terms/rxvt-unicode are you using (or have you tested with both)?
Comment 4 Pierre Guinoiseau 2008-10-06 06:48:44 UTC
I tested it only with rxvt-unicode-9.05.
Comment 5 Pierre Guinoiseau 2008-10-28 17:10:54 UTC
So, when will it be in portage ? Debian already did it ! :)
Comment 6 René Nussbaumer (RETIRED) gentoo-dev 2008-11-01 09:38:16 UTC
This fix is included in 9.05-r3.