Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 240125 - app-text/7plus: CFLAGS are ignored
Summary: app-text/7plus: CFLAGS are ignored
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-05 20:43 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-01-03 21:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix CFLAGS ignoring and pre-strip problem wrt bug 240108 (7plus-2.25.patch,369 bytes, text/plain)
2008-10-08 18:42 UTC, Thomas Beierlein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-05 20:43:30 UTC
I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS properly.

Please look into it, since it's important to respect user CFLAGS.

Thanks,
Diego
Comment 1 Thomas Beierlein gentoo-dev 2008-10-06 04:59:48 UTC
Can not reproduce the problem. See tests below. How do you test that, Diego? 

Test 1:

> emerge --info
...
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -mtune=athlon-4"
CHOST="i686-pc-linux-gnu"
...
> emerge 7plus
...
>>> Compiling source in /var/tmp/portage/app-text/7plus-2.25/work/7plsrc.225 ...
i686-pc-linux-gnu-gcc -c -O2 -mtune=athlon-4 -Wall    7plus.c
i686-pc-linux-gnu-gcc -c -O2 -mtune=athlon-4 -Wall    encode.c


Test 2:

> CFLAGS="will_not_compile" emerge 7plus
...
i686-pc-linux-gnu-gcc -c will_not_compile -Wall    7plus.c
i686-pc-linux-gnu-gcc -c will_not_compile -Wall    encode.c
i686-pc-linux-gnu-gcc: will_not_compile: No such file or directory

Comment 2 Thomas Beierlein gentoo-dev 2008-10-08 18:42:59 UTC
Created attachment 167646 [details]
patch to fix CFLAGS ignoring and pre-strip problem wrt bug 240108

Thanks to Diego's clarification in http://blog.flameeyes.eu/2008/10/08/more-notes-about-the-flags-testing I found the problem. 

Attached patch fixes the problem by sed'ing 'CFLAGS =' into 'CFLAGS +=' in the Makefile.

Be careful as the patch is a cumulative one, which fixes also the pre-strip problem from Bug 240108.
Comment 3 Mike Pagano gentoo-dev 2009-01-03 21:08:50 UTC
03 Jan 2009; Mike Pagano <mpagano@gentoo.org> 7plus-2.25.ebuild:
  Fix for respecting CFLAGS bug #240125 and prestriping binaries bug #240108.
  Patch submitted by Thomas Beierlein. Thank-you, Thomas.