Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 239939 - app-backup/mirdir: pre-stripped files found
Summary: app-backup/mirdir: pre-stripped files found
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prestripped
  Show dependency tree
 
Reported: 2008-10-05 11:52 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-04-15 21:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to mirdir-2.1.ebuild to add a sed command to fix various QA issues (mirdir.ebuild.patch,503 bytes, patch)
2009-01-24 21:52 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-05 11:52:56 UTC
Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Thanks,
Diego
Comment 1 Kevin Pyle 2009-01-24 21:52:51 UTC
Created attachment 179592 [details, diff]
Patch to mirdir-2.1.ebuild to add a sed command to fix various QA issues

The upstream build system overwrites user CFLAGS in the configure script.  Upstream failed to ship their configure.ac, so fixing it in configure is a nuisance.  Instead, patch Makefile.in by appending the value of $CFLAGS before running the configure script.  Also, delete the build rules for mirdir, since those rules stripped the resulting binary.

As a convenience, move the resulting binary from bin/mirdir to ./mirdir so that the GNU make implicit rule handles it correctly.
Comment 2 Christian Ruppert (idl0r) gentoo-dev 2010-04-15 21:43:01 UTC
This bug has been fixed in app-backup/mirdir-2.1-r1.

(In reply to comment #1)
> The upstream build system overwrites user CFLAGS in the configure script. 
> Upstream failed to ship their configure.ac, so fixing it in configure is a
> nuisance.  Instead, patch Makefile.in by appending the value of $CFLAGS before
> running the configure script.  Also, delete the build rules for mirdir, since
> those rules stripped the resulting binary.

My CFLAGS were not be overridden by the configure script so I can't confirm that.
Thanks for your help!