jeroen@elmer ~ $ sr -browser=echo genpkg www-client/surfraw The requested URL /package/www-client/surfraw was not found on this server. jeroen@elmer ~ $ sr -browser=echo genpkg www-client/surfraw http://packages.gentoo.org/package/www-client%2Fsurfraw The genpkg elvi converts slashes to %2F by default. jeroen@elmer ~ $ sr -escape-url-args=no -browser=echo genpkg www-client/surfraw http://packages.gentoo.org/package/www-client/surfraw I wonder whether this used to work on packages.g.o and stopped working after the rewrite. In the latter case, the elvi should be adapted to the new allowed URL scheme.
[Sorry for not replying earlier, but the bugmail landed in my spam folder and I only check that at the end of the month.] * Jeroen Roovers (jer@gentoo.org) wrote: > I wonder whether this used to work on packages.g.o and stopped working > after the rewrite. In the latter case, the elvi should be adapted to the > new allowed URL scheme. I hadn't noticed this since I didn't even realise the service was back online, I've been using something else since about a week after it was taking down for the security problems. Anyhow, there are three choices and the first two are quick fixes: 1. Just dump it, genportage exists in the newest version in the tree (looks like basically a sed of genpkg that opens gentoo-portage.com) 2. Apply the attached fix as a simple workaround, pending new upstream release 3. Hope that the search functionality mentioned in the FAQ[1] is coming soon, or is implemented and just not documented, and update the elvi to use that then. The reason I'm offering up this here before taking a fix upstream is to see if you think it is valuable enough to fix *properly* when there is the gentoo-portage.com elvi already available. I can't really see a use case and would probably suggest removal, but I'll make and attempt to upstream a proper fix if you think it adds value. Thanks, James 1. http://packages.gentoo.org/faq/
Created attachment 173724 [details, diff] surfraw-2.2.2-remove_genpkg_quoting.patch This patch just removes *all* URL encoding for genpkg, as packages can't include any of the other encoded characters in their name it shouldn't reduce functionality. The patch applies clean to both versions in the tree, or a simple `sed -i 16iSURFRAW_escape_url_args=0 elvi/genpkg` does the same trick(it is how I did the edit for the patch ;) ).
(In reply to comment #1) > 3. Hope that the search functionality mentioned in the FAQ[1] is coming > soon, or is implemented and just not documented, and update the > elvi to use that then. It has been two years, so I think option 3 is off the table. I'm leaning heavily toward the "just dump the genpkg elvi" option still, any extra input before I push the change?
Remove your quoting in generating that argument. I'm pretty sure it's not valid like that. (Alternatively, if you can prove per HTTP specs that I should treat the URLs that same, I'll see about the packages.g.o end).
(In reply to comment #4) > Remove your quoting in generating that argument. I'm pretty sure it's not valid > like that. My bad. That wasn't really what I referring to, I should have been more clear. Removing the quoting never really seemed like a worthwhile long term change. Every other search tool in the surfraw package hits a search page, as a user I'd expect genpkg to show me search results with "genpkg nvidia" not just redirect me to the front page. And, this is the reason I came back to this bug today as I received a bug report about just that behaviour. I should have referenced the final paragraph of comment #1 when I phrased my question. I'll try again: am I missing a compelling reason to keep the packages.gentoo.org elvi when an alternative with search exists(genportage which uses gentoo-portage.com).
Bug #318947 contains a bump request for the v2.2.7 release, which has removed the genpkg evli.
