The reiser4progs patch added in 1.0.6-r1 adding -p "preen" support to reiser4progs is implemented wrongly, causing a fsck on every boot, including when the filesystem is marked clean. Boot time on my usb pen: with old patch : 4 minutes 23 seconds with my patch : 41 seconds. This is obviously a pretty big flaw. Please see http://thread.gmane.org/gmane.comp.file-systems.reiserfs.general/21324 for more information, Edward Shishkin (current reiser4 maintainer) confirms that this patch is correct behavior. The only thing it'll break is docs (refering to -p as list plugins, not preen). I've used reiser4 on and off on different media for a while now, and thought reiser4 fsck was this slow during it's development period, so this patch is obviously a pretty big bug from the gentoo team, especially for something this easy to fix, therefor marking as major. Reproducible: Always
Created attachment 165196 [details, diff] Let -p "preen" fallthrough to -a "auto".
vapier: Did you have some comments on this one. Confusing looking at the related bug and whatnot. thx
(In reply to comment #0) > The reiser4progs patch added in 1.0.6-r1 adding -p "preen" support to > reiser4progs is implemented wrongly, causing a fsck on every boot, including > when the filesystem is marked clean. > > Boot time on my usb pen: > with old patch : 4 minutes 23 seconds > with my patch : 41 seconds. > > This is obviously a pretty big flaw. > > Please see > http://thread.gmane.org/gmane.comp.file-systems.reiserfs.general/21324 for more > information, Edward Shishkin (current reiser4 maintainer) confirms that this > patch is correct behavior. Actually, I didn't. Please, consider the let-preen-fall-through-to-auto patch. Checking a reiser4 partition on every boot is wrong behavior. It is not supposed to be checked even after hard reset.. Thanks, Edward.
Yes, this patch works for me. Thanks for the patch!
if it works for you guys, that's fine by me ... ive added 1.0.6-r2 with it, thanks! http://sources.gentoo.org/sys-fs/reiser4progs/files/reiser4progs-1.0.6-preen.patch?r1=1.1&r2=1.2
*** Bug 226463 has been marked as a duplicate of this bug. ***
