Bug 235013 – net-print/libgnomecups-0.2.3 : libgnomecups-1.0.pc reports unwanted libraries

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexis Ballier 2008-08-17 13:42:32 UTC]

I removed kerberos support from cups but I still have this in libgnomecups-1.0.pc:

Libs: -L${libdir} -lgnomecups-1.0 -lcups -L/usr/lib64 -Wl,-rpath -Wl,/usr/lib64 -march=athlon64 -O2 -pipe -g -ggdb -DLDAP_DEPRECATED -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -DDBUS_API_SUBJECT_TO_CHANGE -Wl,--as-needed -Wl,-O1 -Wl,--sort-common -Wl,--hash-style=gnu -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lresolv -ldl -L/usr/lib64 -lgnutls -L/usr/lib64 -ltasn1 -L/usr/lib64 -lgcrypt -lgpg-error -lz -lpthread -lm -lcrypt


This causes (at least) libgnomeprint to needlessly link to kerberos libs and causes it to fail to rebuild once kerberos support has been removed from cups but libgnomecups has not been rebuilt.

libgnomecups-1.0.pc.in contains:
Libs: -L${libdir} -lgnomecups-1.0 @CUPS_LIBS@

This should be Libs.private, since that's probably needed for static linking, but I doubt we need to link to cups if we dynamically link to libgnomecups (since the elf format handles library dependencies afaik).


Changing the .pc.in to have:
Libs: -L${libdir} -lgnomecups-1.0
Libs.private: -L${libdir} -lgnomecups-1.0 @CUPS_LIBS@

seems more sane and safe.

[Comment 1 Gilles Dartiguelongue (RETIRED) 2008-10-15 21:04:41 UTC]

the change you proprose sounds sensible, did you report this upstream or shall we ?

[Comment 2 Pacho Ramos 2010-03-19 16:48:35 UTC]

(In reply to comment #1)
> the change you proprose sounds sensible, did you report this upstream or shall
> we ?
> 

Alexis? Thanks

[Comment 3 Alexis Ballier 2010-03-19 16:58:40 UTC]

(In reply to comment #2)
> (In reply to comment #1)
> > the change you proprose sounds sensible, did you report this upstream or shall
> > we ?
> > 
> 
> Alexis? Thanks

I don't remember doing so and have nothing in my mailbox; please do report it

[Comment 4 Pacho Ramos 2010-03-19 17:17:52 UTC]

Done ;-)

[Comment 5 Pacho Ramos 2011-02-01 10:22:01 UTC]

Since upstream is dead and, sadly, there are still some apps that will need this, do people agree with committing change suggested by Alexis in comment #0 ?

[Comment 6 Gilles Dartiguelongue (RETIRED) 2011-02-01 13:14:22 UTC]

I wonder why -L${libdir} is even added

[Comment 7 Pacho Ramos 2011-02-24 17:32:30 UTC]

(In reply to comment #6)
> I wonder why -L${libdir} is even added
> 

Alexis, have you tried without -L$(libdir) ?

[Comment 8 Pacho Ramos 2011-04-14 17:58:24 UTC]

Will commit Alexis suggestion in the near future, if you also want to drop -L${libdir} please tell me so

Thanks

[Comment 9 Pacho Ramos 2011-05-08 11:27:27 UTC]

+*libgnomecups-0.2.3-r1 (08 May 2011)
+
+  08 May 2011; Pacho Ramos <[e-mail]> +libgnomecups-0.2.3-r1.ebuild,
+  +files/libgnomecups-0.2.3-pkgconfig.patch:
+  Revision bump to fix pkgconfig file as noted by Alexis Ballier in bug
+  #235013.
+