Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 234300 - portage-2.2-rc6 breaks check_license() from eutils.eclass with --jobs
Summary: portage-2.2-rc6 breaks check_license() from eutils.eclass with --jobs
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on: 152593 233296
Blocks: 288499 299095
  Show dependency tree
 
Reported: 2008-08-09 10:47 UTC by Justin Lecher (RETIRED)
Modified: 2010-02-21 23:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2008-08-09 10:47:08 UTC
Tried to install app-emulation/virtualbox-additions with "-v --jobs=3" and the license doesn't show up. So it is impossible to install such packages with --jobs.
W/o --jobs everything is fine.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2008-08-28 17:59:53 UTC
What makes everything worse is that in case of cancelling the merge, while is not shown up, the courser is hidden afterwards.
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2008-08-28 18:03:39 UTC
What I wanted to say, term echoing is still off.
Comment 3 Chris Gianelloni 2008-09-17 19:19:18 UTC
This problem is parallel (hehe) to the one about which I was about to file a bug.

Basically, check_license needs to be updated to do nothing when it finds a portage version that supports license filtering.

When was license filtering introduced?  When was --jobs introduced?
Comment 4 Zac Medico gentoo-dev 2008-09-17 21:17:50 UTC
License filtering first appeared in 2.2_pre1 and --jobs first appeared in 2.2_rc2.
Comment 5 Chris Gianelloni 2008-09-17 21:43:17 UTC
Excellent!  Since we want to skip the license check, entirely, for versions of portage which implement license filtering, all that should need to be done is:

 check_license() {
+	# Newer portage versions support license filtering.
+	has_version ${ROOT} >=sys-apps/portage-2.2_pre1 && return 0
 	local lic=$1

Zac, wouldn't you agree?

Also, do you know if the other package managers support license filtering?  If so, we'd probably want to extend the check to the appropriate version of those tools, too.
Comment 6 Zac Medico gentoo-dev 2008-09-26 18:18:33 UTC
Due to compatibility issues, we need to define all the license groups and use them to define the default ACCEPT_LICENSE in the profile before we can enable license masking as it's intended. After we've got the license groups and ACCEPT_LICENSE, we can release a new version of portage that is reliant upon them.
Comment 7 Zac Medico gentoo-dev 2008-11-02 01:20:50 UTC
It think what we should probably do is set PROPERTIES=interactive in all the check_license() ebuilds for now. That solves the immediate problem (same as bug 233296). Once we have the license groups configured in the profiles, and the required version of portage is marked stable, we can tweak check_license() as suggested in comment #5 and remove PROPERTIES=interactive from the ebuilds.
Comment 8 Zac Medico gentoo-dev 2009-10-12 19:39:20 UTC
We can remove PROPERTIES=interactive from the check_license() ebuilds after portage-2.1.7.x is marked stable, approximately 1 month from now.
Comment 9 Zac Medico gentoo-dev 2010-02-21 23:04:21 UTC
I'm marking this as fixed since any ebuilds that call check_license with EAPI < 3 should have PROPERTIES=interactive set. For EAPI >= 3, PROPERTIES=interactive is unnecessary due to ACCEPT_LICENSE support. See bug 299095, comment #2.