Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 232528 - linm ebuild
Summary: linm ebuild
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2008-07-21 00:15 UTC by Andrew Savchenko
Modified: 2018-05-16 16:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
linm ebuild (linm-0.8.1.ebuild,1.07 KB, text/plain)
2008-07-21 00:16 UTC, Andrew Savchenko
Details
updated ebuild as suggested by Carsten Lohrke (linm-0.8.1.1.ebuild,948 bytes, text/plain)
2008-07-21 11:19 UTC, Andrew Savchenko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2008-07-21 00:15:10 UTC
LinM is a good UTF-8 compatible replacement for mc.
Homepage: http://wiki.kldp.org/wiki.php/%C3%D6%C0%BA%BC%AD
ebuild is taken from here: http://kldp.net/frs/download.php/4592/linm-0.8.1.ebuild
Comment 1 Andrew Savchenko gentoo-dev 2008-07-21 00:16:27 UTC
Created attachment 160974 [details]
linm ebuild
Comment 2 Carsten Lohrke (RETIRED) gentoo-dev 2008-07-21 00:42:40 UTC
- Don't inherit eclasses you never use.
- GPL is not a valid license reference, see /usr/portage/licenses
- Don't hardcode the version in the ebuild as you did in $SRC_URI
- You tested on all keyworded architectures?
- Usually gettext is only needed at build-, not runtime.
- Remove src_unpack(), Portage does it for you. You may have to adjust $S, though.
- The build script is a custom one, so $(use_enable foo) can't be used?
- A single local variable instead *conf would be preferable.

Last but not least: Do you think you hook someone with such an extra short bug title?
Comment 3 Andrew Savchenko gentoo-dev 2008-07-21 11:15:53 UTC
Dear Carsten, I'm not author of this ebuild, I thought this is obvious from package description. I just reposted it from the official site of LinM: it works for me, thus may be usefull for another people.

Anyway, on the second thought, if I submitted this ebuild, I became responsible for its QA, so I will follow your suggestions.

> You tested on all keyworded architectures?
I peronally tested on x86 and amd64, but I assumed that linm developers (who created the original ebuild and there are quite big bunch of them) tested it on all declared architectures. Well, currently I change the keywords to ~x86 and ~amd64.

> Usually gettext is only needed at build-, not runtime.
This program is an exeption: it uses gettext-like format in it's config files, so it use gettext during config files parsing.

> The build script is a custom one, so $(use_enable foo) can't be used?
It can and will be used with an exception: use ssl => --enable-sftp.

All another remarks were fixed too.

> Do you think you hook someone with such an extra short bug title?
Well, do you have a better idea for new ebuild bug title? Detailed description is in Description field. 

However, you just proved that it may attract people by its peculiarity: your feedback was very fast. There some of my rather good bugreports or patches which are silently ignored for a lot of weeks. (No offence: I understand, developers are busy and people are free to do what they want here.)
Comment 4 Andrew Savchenko gentoo-dev 2008-07-21 11:19:14 UTC
Created attachment 160993 [details]
updated ebuild as suggested by Carsten Lohrke
Comment 5 Marek Szuba archtester gentoo-dev 2018-05-15 15:44:19 UTC
Upstream stalled a long, long time ago, and in the meantime Midnight Commander received decent UTF-8 support. Is there anyone still interested in adding this to the tree? If not, I shall close this bug as WONTFIX in 30 days.
Comment 6 Andrew Savchenko gentoo-dev 2018-05-16 16:32:47 UTC
I have no interest. It was needed only why mc was almost dead and without UTF-8.