Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 232403 - net-wireless/ndiswrapper - No kernel config checks used
Summary: net-wireless/ndiswrapper - No kernel config checks used
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-20 02:41 UTC by Roger
Modified: 2010-06-22 21:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roger 2008-07-20 02:41:54 UTC
ndiswrapper & madwifi-ng driver ebuilds are not doing proper kernel config checking.

These ebuilds should check for wireless_extensions within linux/net/wireless.

(Granted, these appear deprecated according to the kernel help menu, but they are required build deps still for the latest ndiswrapper & madwifi drivers!)



Reproducible: Always

Steps to Reproduce:
emerge ndiswrapper || emerge madwifi-ng



Actual Results:  
build fails if wireless_extensions are not activated within the kernel

Expected Results:  
ebuilds never check kernel config file for proper configuration

(Is there a good reason for the lack of checking?  If not, this demonstrates poor programming practice.)
Comment 1 franky 2008-07-20 05:49:09 UTC
Both ebuilds do check for it ('old' wireless stack) and abort without required kernel options. Following is pasted from madwifi-ng ebuild.

---8< snip ----
CONFIG_CHECK="CRYPTO WIRELESS_EXT SYSCTL KMOD"
ERROR_CRYPTO="${P} requires Cryptographic API support (CONFIG_CRYPTO)."
ERROR_WIRELESS_EXT="${P} requires CONFIG_WIRELESS_EXT selected by Wireless LAN drivers (non-hamradio) & Wireless Extensions"
---8< snip ---
Comment 2 Roger 2008-07-20 10:37:17 UTC
So the question is, why did it fail to not catch the lack of wireless_ext within my /usr/src/linux/.config?

For some reason, on both the latest ndiswrapper & madwifi-ng ebuilds, they both passed the checks, but failed while compiling with a compiler complaint of something to the extent "no wireless_ext defined". After figuring out I was lacking the old deprecated code (config option), I then enabled it and things compiled just fine.

<stumped>
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2008-07-20 20:34:47 UTC
=== Summaries Are Not Like Titles At All ===
=== But More Like a Sentence Describing  ===
=== What the Actual Bug Report Is About  ===
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2008-07-20 20:37:28 UTC
Please file a similar bug report for net-wireless/madwifi-ng - the ebuilds for either package are maintained by different groups of developers.
Comment 5 Roger 2008-07-24 01:45:48 UTC
As for the summary, I try to make it as descriptive as possible for users searching for bugs via bugs.gentoo.org as they get truncated after five to six words.

Sounds good, thanks for moving to madwifi-ng.
Comment 6 Christoph Mende (RETIRED) gentoo-dev 2010-06-22 21:18:09 UTC
successfully fails for me on 1.56