Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 231472 - >=sys-apps/debianutils-2.29 breaks installkernel for non-"modern" systems
Summary: >=sys-apps/debianutils-2.29 breaks installkernel for non-"modern" systems
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://bugs.debian.org/cgi-bin/bugrep...
Whiteboard:
Keywords:
Depends on:
Blocks: 273060
  Show dependency tree
 
Reported: 2008-07-11 00:25 UTC by Jeroen Roovers (RETIRED)
Modified: 2010-09-10 06:16 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
debian-utils-2.29-installkernel.patch (debian-utils-2.29-installkernel.patch,700 bytes, patch)
2008-07-11 00:26 UTC, Jeroen Roovers (RETIRED)
Details | Diff
debian-utils-2.29-installkernel.patch (debian-utils-2.29-installkernel.patch,1.62 KB, patch)
2008-07-11 00:59 UTC, Jeroen Roovers (RETIRED)
Details | Diff
debian-utils-2.29-installkernel.patch (debian-utils-2.29-installkernel.patch,1.56 KB, patch)
2008-07-11 01:13 UTC, Jeroen Roovers (RETIRED)
Details | Diff
debianutils-2.30-installkernel.patch (debianutils-2.30-installkernel.patch,754 bytes, patch)
2009-03-13 00:12 UTC, Sebastian Günther
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2008-07-11 00:25:07 UTC
The patch of [URL] was apparently applied without any checks on the non-modern system it is purport to still support. On a system where any of /boot/{vmlinu[xz],config,System.map} is a symlink, installkernel now unreasonably requires it to be a symlink to the kernel version to be installed as well, or it will not do any symlinking. Worse still, if that is not the case (either condition fails), it replaces the symlink with a copy of the file and the old symlinking behaviour is lost forever[1], because on the next run of installkernel, it fails on the first requirement.

[1] That is, until the symlinks are restored and the soon to be attached patch is installed...
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2008-07-11 00:26:20 UTC
Created attachment 160097 [details, diff]
debian-utils-2.29-installkernel.patch
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-07-11 00:40:29 UTC
The reasoning behind Debian's installkernel patch appears to be that the symlinks are only interesting for systems that use lilo as bootloader. The "modern" predicate appears to indicate a preference for grub, which Debian only uses for amd64 and i386. All the other arches that Debian and indeed Gentoo supports are left out in the cold.

At the end of installkernel, the call to mkboot has been commented. Again, this is good for grub users but ignores other bootloader installers' modes of operation.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2008-07-11 00:59:49 UTC
Created attachment 160100 [details, diff]
debian-utils-2.29-installkernel.patch

Introduce the same test -L logic where it concerns running mkboot.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2008-07-11 01:13:08 UTC
Created attachment 160102 [details, diff]
debian-utils-2.29-installkernel.patch

Ew, I fell into the same trap.
Comment 5 SpanKY gentoo-dev 2008-08-17 17:46:55 UTC
this really should be sent to bugs.debian.org seeing as how they maintain it
Comment 6 Philipp Riegger 2008-10-14 21:26:34 UTC
I hit the same bug. 
Comment 7 Sebastian Günther 2009-02-07 07:31:26 UTC
Is it possible, that this patch is not applied to 2.30?

Since I don't have symlink support since 2.30.
Comment 8 Raúl Porcel (RETIRED) gentoo-dev 2009-02-18 17:02:54 UTC
Jer please send it?
Comment 9 Sebastian Günther 2009-03-12 23:18:39 UTC
The last patch is by the way faulty, because it tries to revert the earlier version of patches, which are of course not applicable to the original source.
Comment 10 Sebastian Günther 2009-03-13 00:12:03 UTC
Created attachment 184863 [details, diff]
debianutils-2.30-installkernel.patch

I adopted Jeroen's patches, so that the symlink logic with vmlinuz and vmlinuz.old as it was before: added move if versions mismatch.

I just not into mkboot, so I will leave that to someone more skilled.
Comment 11 Matt Whitlock 2009-04-24 01:34:27 UTC
I have my /boot on a very small USB flash media.  I enjoyed the symlinking behavior because it resulted in fewer pages written to my flash and wasted less space.  Now I have two identical copies of each of vmlinuz and vmlinuz.old:

-rw-r--r-- 1 root root 1977728 2009-04-23 21:17 vmlinuz
-rw-r--r-- 1 root root 1998880 2009-03-03 22:43 vmlinuz-2.6.27-gentoo-r8
-rw-r--r-- 1 root root 1977728 2009-04-23 21:17 vmlinuz-2.6.28-gentoo-r5
-rw-r--r-- 1 root root 1998880 2009-03-03 22:43 vmlinuz.old

They are not even hard links of the same inode.  They are separate copies, wasting space.

Do we have a Debian bug report number for this patch yet?
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2009-05-01 14:04:14 UTC
(In reply to comment #11)
> Do we have a Debian bug report number for this patch yet?

I have sent a second e-mail reply through the bug referenced in this bug report's URL field. I had done so previously but it appears to have gone to /dev/null, since I never got any feedback.
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2009-05-01 15:31:43 UTC
Reported as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526493
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2009-05-01 16:52:17 UTC
Version 3.0.1 is in the tree. It no longer provides mkboot and it might fix the symlinking issue. Else we wait until 3.0.2 is uploaded.
Comment 15 Jeroen Roovers (RETIRED) gentoo-dev 2009-05-02 16:00:29 UTC
Version 3.0.2 is in the tree now.
Comment 16 Jeroen Roovers (RETIRED) gentoo-dev 2009-06-07 15:45:38 UTC
Is there anything against the way 3.1.3 handles this?
Comment 17 Sebastian Günther 2009-06-07 17:14:59 UTC
symlinking works fine.
Comment 18 Constantin Baranov 2009-07-15 18:44:41 UTC
I'm happy with 3.1 and 3.2.