Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 230047 - games-strategy/glest-2.0.1 needs additional includes
Summary: games-strategy/glest-2.0.1 needs additional includes
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Games
Keywords: REVIEWED
Depends on:
Blocks: gcc-4.3
  Show dependency tree
Reported: 2008-06-29 16:02 UTC by Will Saxon
Modified: 2008-11-23 20:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Fix includes for gcc-4.3 (glest-2.0.1-gcc-4.3.patch,1.19 KB, patch)
2008-09-16 14:06 UTC, Petr Zima
Details | Diff
Ebuild with gcc-4.3 patch (glest-2.0.1.ebuild,2.42 KB, text/plain)
2008-09-16 14:07 UTC, Petr Zima

Note You need to log in before you can comment on or make changes to this bug.
Description Will Saxon 2008-06-29 16:02:46 UTC
With gcc 4.3.1 I was not able to get glest-2.0.1 to build. There are errors about undeclared functions in 3 source files.

Reproducible: Always

Steps to Reproduce:
1.emerge gcc-4.3.1
2.make gcc-4.3.1 your default compiler
3.attempt to emerge glest-2.0.1
Actual Results:  
emerge failed

Expected Results:  
emerge succeeds

Portage (default-linux/amd64/2007.0, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.25-tuxonice-r4 x86_64)
System uname: 2.6.25-tuxonice-r4 x86_64 AMD Athlon(tm) 64 Processor 3000+
Timestamp of tree: Thu, 26 Jun 2008 22:45:03 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.5.2-r5
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-devel/autoconf:  2.13, 2.62
sys-devel/automake:  1.5, 1.7.9-r1, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r2
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="amd64 ~amd64"
CFLAGS="-O3 -march=athlon64 -pipe -fomit-frame-pointer"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O3 -march=athlon64 -pipe -fomit-frame-pointer"
FEATURES="distlocks parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
LINGUAS="en en_US"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTDIR_OVERLAY="/usr/portage/local/layman/gentoo-china /usr/portage/local/layman/desktop-effects"
USE="3dnow X a52 aac acl acpi alsa amd64 arts bash-completion berkdb bzip2 cairo cddb cdparanoia cli cracklib crypt css cups dbus dri dvd dvdr ffmpeg flac gdbm gif gimp gnutls gpm hal hddtemp iconv icu isdnlog java joystick jpeg kde lm_sensors logitech-mouse matroska midi mmap mmx mng mp3 mpeg mplayer mudflap ncurses newspr nls nptl nptlonly nsplugin ogg opengl openmp pam pcre pdf perl png pppd python qt3 qt4 readline reflection sdl session spl sse sse2 ssl svg syslog tcpd theora threads tiff truetype unicode usb vim-syntax vorbis x264 xcb xcomposite xine xml xorg xscreensaver xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x        ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3      trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="worker" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_US" USERLAND="GNU" VIDEO_CARDS="nv nvidia"
Comment 1 Will Saxon 2008-06-29 16:08:40 UTC
I am still having trouble submitting attachments to bugzilla, so here is a patch I made which will enable the software to compile successfully:

--- /var/tmp/portage/games-strategy/glest-2.0.1/work/source/shared_lib/sources/util/./conversion.cpp  2008-06-29 11:56:39.545360436 -0400
+++ ./conversion.cpp    2008-06-29 11:27:08.542679368 -0400
@@ -13,6 +13,7 @@

 #include <stdexcept>
 #include <cstdio>
+#include <cstdlib>

 #include "leak_dumper.h"

--- /var/tmp/portage/games-strategy/glest-2.0.1/work/source/shared_lib/sources/util/./properties.cpp  2008-06-29 11:56:40.209401722 -0400
+++ ./properties.cpp    2008-06-29 11:27:08.550678991 -0400
@@ -13,6 +13,9 @@

 #include <fstream>
 #include <stdexcept>
+#include <cstring>
+#include <cstdlib>
+#include "linux/limits.h"

 #include "conversion.h"
 #include "leak_dumper.h"

--- /var/tmp/portage/games-strategy/glest-2.0.1/work/source/shared_lib/sources/util/./util.cpp  2008-06-29 11:56:39.589363527 -0400
+++ ./util.cpp  2008-06-29 11:27:08.558680289 -0400
@@ -14,6 +14,7 @@
 #include <ctime>
 #include <cassert>
 #include <stdexcept>
+#include <cstdlib>

 #include "leak_dumper.h"
Comment 2 Petr Zima 2008-09-16 14:05:13 UTC
Confirming this bug and that the patch fixes it on x86 (gcc-4.3.1-r1, glibc-2.8_p20080602, paludis-0.30.0). Attaching new ebuild and patch (with cosmetic modification "linux/limits.h" -> <climits>).
Comment 3 Petr Zima 2008-09-16 14:06:55 UTC
Created attachment 165560 [details, diff]
Fix includes for gcc-4.3
Comment 4 Petr Zima 2008-09-16 14:07:22 UTC
Created attachment 165561 [details]
Ebuild with gcc-4.3 patch
Comment 5 Mark Loeser (RETIRED) gentoo-dev 2008-11-23 20:03:20 UTC
This has been fixed by the bump to glest-3.1.2