Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226893 - games-action/snipes: append-ldflags is used to pass libraries
Summary: games-action/snipes: append-ldflags is used to pass libraries
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: append-ldflags-libs
  Show dependency tree
 
Reported: 2008-06-14 18:14 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-09-04 21:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild without append-ldflags (snipes-1.0.2.ebuild,580 bytes, text/plain)
2008-07-05 15:06 UTC, Cyp
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-14 18:14:21 UTC
I've made append-ldflags throw a warning when libraries are passed through it
to link them in.

The reason is that LDFLAGS should _not_ be used for libraries, as it has to be
positioned before the list of objects to link together, while libraries should
go after.

This mistake in commandline is what causes as-needed to either fail or not
apply at all (if LDFLAGS are put at the end).

Please fix your package not to pass libraries through LDFLAGS.
Comment 1 Cyp 2008-07-05 15:06:57 UTC
Created attachment 159632 [details]
Ebuild without append-ldflags

I've removed append-ldflags from the ebuild.

The biggest difference between 1.0.1 and 1.0.2 is that 1.0.2 has a Makefile. Some unused variables and unused functions have been deleted. The code should behave the same.
Comment 2 Tristan Heaven (RETIRED) gentoo-dev 2008-09-04 21:05:09 UTC
Fixed, thanks.