Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226837 - x11-libs/libgksu: libs are being passed through _LDFLAGS
Summary: x11-libs/libgksu: libs are being passed through _LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Gryniewicz (RETIRED)
URL: https://savannah.nongnu.org/bugs/?25362
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-06-14 17:42 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-01-19 21:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-14 17:42:06 UTC 
If you check the -fbsd patch you can easily see that libraries used for linking the tests are passed through _LDFLAGS. This is probably caused by automake hissing about "--libs" that should be passed through _LDFLAGS rather than _LDFLAGS.

Both are wrong. The configure script should use PKG_CHECK_MODULES for glib-2.0 and then the variables read there should be used in the Makefile.am.

As it is it will break with --as-needed.
Comment 1 Daniel Gryniewicz (RETIRED) gentoo-dev 2008-06-25 14:35:43 UTC 
It actually builds fine with --as-needed.
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2008-06-25 14:46:43 UTC 
(In reply to comment #0)
> should be passed through _LDFLAGS rather than _LDFLAGS.

I'm sure there's something wrong with this bit ;)
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-25 14:58:39 UTC 
Uh yeah that was meant to be _LIBS :P

As for building with --as-needed, as long as libtool reorders the parameters sure it works... I'm bypassing libtool though by forcing it in the specs.
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-01-19 21:31:02 UTC 
fixed in 2.0.7 bump. Please reopen if there is still a problem.