The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild. This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt. This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible. Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.
That's done to split the upstream tarball into 2 separate ebuilds : gtk-doc and gtk-doc-am. This is perfectly justified :) ie, not a bug. Closing
Err and cannot gtk-doc just patch Makefile.am and rebuild autotools like any other package?
Good point. Would only changing Makefile.in be enough for you? None of us in the gnome herd are big fans of running eautoreconf when it can be avoided. And in that particular case, it's just a matter of dropping a file from being installed. Trivial and harmless enough, ihmo.
Check my blog for why you should run eautoreconf.. I'll write something more tomorrow on why _not_ to patch just .in.
why not simply remove the file at src_install ? No patch, no autoreconf, everyone is happy.
(In reply to comment #5) > why not simply remove the file at src_install ? No patch, no autoreconf, > everyone is happy. > Seems to be fixed in that way at least since 1.13: # Don't install those files, they are in gtk-doc-am now rm "${D}"/usr/share/aclocal/gtk-doc.m4 || die "failed to remove gtk-doc.m4" rm "${D}"/usr/bin/gtkdoc-rebase || die "failed to remove gtkdoc-rebase"