Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226351 - dev-libs/confuse: builds examples/demos (that are not installed)
Summary: dev-libs/confuse: builds examples/demos (that are not installed)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: MATSUU Takuto (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: test-n-example-build
  Show dependency tree
 
Reported: 2008-06-13 13:12 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-07-09 10:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
improves ebuild (confuse-2.6-r3.ebuild.patch,1.27 KB, patch)
2009-03-02 02:23 UTC, Nathan Phillip Brink (binki) (RETIRED)
Details | Diff
similar to flameeye's sample patch (confuse-2.6-noexamples.patch,1.07 KB, patch)
2009-03-02 02:59 UTC, Nathan Phillip Brink (binki) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-13 13:12:53 UTC
The package seems to be building examples during "make all" phase even though they are not installed at all. For details see my blog: http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default .

It would be nice if the examples were not built by default and (maybe) only built with FEATURES=test (as a able-to-link test). You can find an example patch usually suitable for upstream on the blog above.

Thanks,
Diego
Comment 1 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2009-03-02 01:11:15 UTC
(In reply to comment #0)
> The package seems to be building examples during "make all" phase even though
> they are not installed at all. For details see my blog:
> http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default
I completely agree with this idea[l].

I found this unnecessary compilation a problem while trying to crosscompile dev-libs/confuse for mingw32. The examples and tests for confuse include usage of things like SIGUSR1 and SIGHUP that mingw32 doesn't define. Thus, I couldn't emerge confuse to $SYSROOT because make bailed out when GCC spat out errors for the examples.

> 
> It would be nice if the examples were not built by default and (maybe) only
> built with FEATURES=test (as a able-to-link test).
I'm pretty sure that the files in examples/ are not used by make check.
> You can find an example
> patch usually suitable for upstream on the blog above.
I submitted a patch to upstream via the mailing list ( http://lists.nongnu.org/archive/html/confuse-devel/2009-02/msg00002.html ). I haven't gotten any response yet, though. In making the patch, I got stuck for a few hours figuring out why my variable assignment didn't work (I prefixed the variable name with a tab instead of spaces to indent it which kept make from assigning the variable :-) ).

The patch works for dev-libs/confuse-2.6 as well as the CVS version.
Comment 2 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2009-03-02 02:23:04 UTC
Created attachment 183640 [details, diff]
improves ebuild

Adds lines to run epatch ${P}-noexample.patch
Also adds dodoc lines to actually install the examples for the user - they are examples, after all :-) (though maybe I should have dodoc'd the directory rather than the individual files?)
Comment 3 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2009-03-02 02:59:24 UTC
Created attachment 183644 [details, diff]
similar to flameeye's sample patch
Comment 4 Didier Barvaux 2010-04-10 12:37:31 UTC
This bug is now fixed by the ebuild version bump requested in bug 306295. Please close it.

From dev-libs/confuse/ChangeLog:

  *confuse-2.7 (19 Mar 2010)

    19 Mar 2010; MATSUU Takuto <matsuu@gentoo.org> +confuse-2.7.ebuild:
    Version bumped. the ebuild was submitted by Nathan Phillip Brink, bug
    #306295.
Comment 5 Didier Barvaux 2010-05-07 19:25:17 UTC
Noone to mark this 2-year-old bug as resolved?
Comment 6 Tomáš Chvátal (RETIRED) gentoo-dev 2010-07-09 10:15:25 UTC
Aye this is fixed in the latest version in main tree.