The package seems to be building tests during "make all" phase even though I don't have FEATURES=test enabled. For details see my blog: http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default . It would be nice if the tests were disabled by default and only built with FEATURES=test. You can find an example patch usually suitable for upstream on the blog above. Thanks, Diego
changing severity for easier searching.
I created a patch that change the noinst_* targets in several Makefile.am files in check_* targets. This way, several programs and one library are not built if make check is not run. I'm going to attach the patch for librsvg-2.26.0 sources and the patch for the gnome-base/librsvg-2.26.0 ebuild.
Created attachment 225477 [details, diff] Change noinst_* targets into check_* targets in librsvg-2.26.0 sources
Created attachment 225479 [details, diff] Update gnome-base/librsvg-2.26.0 ebuild to patch sources
I proposed the enhancement upstream, see https://bugzilla.gnome.org/show_bug.cgi?id=614123.
Thanks, but upstream would probably prefer a patch against current master or 2.30 instead Anyway, thanks a lot for looking into this :-)
(In reply to comment #6) > Thanks, but upstream would probably prefer a patch against current master or > 2.30 instead > > Anyway, thanks a lot for looking into this :-) > The patch was created against master in git repository (git://git.gnome.org/librsvg) and it applies cleanly on 2.26.0, so it should be OK for both Gentoo and upstream :)
Great to know
Upstream bug was solved. My first patch (that used check_* targets) was rejected, but a new one (that uses an --enable-tools) was accepted and committed. The accepted patch is there: http://git.gnome.org/browse/librsvg/commit/?id=4e7f090d1b2e2bb7c6a47d6f45edc8adb335e9a3 I'm going to update the patches attached to this bug in consequence.
Created attachment 228227 [details, diff] Add --enable-tools/--disable-tools options to avoid building miscellaneous tools
Created attachment 228229 [details, diff] Update gnome-base/librsvg-2.26.0 ebuild too apply the new patch
+ 18 Apr 2010; Pacho Ramos <pacho@gentoo.org> librsvg-2.26.2.ebuild, + +files/librsvg-2.26.2-choosable-tools.patch, metadata.xml: + Build misc tools only when desired (bug #226231). Thanks a lot to Didier + Barvaux for his work on this.
(In reply to comment #12) > + 18 Apr 2010; Pacho Ramos <pacho@gentoo.org> librsvg-2.26.2.ebuild, > + +files/librsvg-2.26.2-choosable-tools.patch, metadata.xml: > + Build misc tools only when desired (bug #226231). Thanks a lot to Didier > + Barvaux for his work on this. > Thanks Pacho. I tried the updated =gnome-base/librsvg-2.26.2 ebuild but it fails to build. The failure is probably not related to the new patch because it fails with or without USE=tools. I opened bug #315953 to track the issue. In the meanwhile, I can not confirm if your change for bug #226231 works or not.
It's probably because you need to update to gtk-doc-am-1.13 , but we will continue on bug 315953 for that issue ;-) Best regards
(In reply to comment #14) > It's probably because you need to update to gtk-doc-am-1.13 , but we will > continue on bug 315953 for that issue ;-) > > Best regards > Yes, your advice solved the problem. I installed the =gnome-base/librsvg-2.26.2 ebuild. I confirm that the change for disabling tools works. This bug may be closed.
