Bug 226207 – dev-libs/geoip: builds tests with FEATURES=-test

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2008-06-13 11:09:33 UTC]

The package seems to be building tests during "make all" phase even though I don't have FEATURES=test enabled. For details see my blog: http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default .

It would be nice if the tests were disabled by default and only built with FEATURES=test. You can find an example patch usually suitable for upstream on the blog above.

Thanks,
Diego

[Comment 1 Olivier Huber 2008-06-26 13:48:09 UTC]

Created attachment 158507 [details, diff]
patch proposal

This should solve this issue.

Here is the ebuild's diff : 

--- geoip-1.4.4.ebuild~ 2008-06-26 14:50:55.000000000 +0200
+++ geoip-1.4.4.ebuild  2008-06-26 15:06:26.000000000 +0200
@@ -23,8 +23,9 @@
        unpack ${A}
        cd "${S}"

-       # FreeBSD requires this
-       elibtoolize
+       epatch "${FILESDIR}/${PN}-disable-test-building-during-compile-phase.patch"
+
+       eautoreconf
 }

 src_compile() {

[Comment 2 Peter Volkov (RETIRED) 2008-09-24 12:35:36 UTC]

Thank you Diego and Olivier. I've applied similar patch (and btw, sent patch upstream and they accepted it :) ). Fixed in geoip-1.4.5.