Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 225759 - app-misc/ca-certificates should depend on debianutils
Summary: app-misc/ca-certificates should depend on debianutils
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-10 14:25 UTC by Alan Hourihane
Modified: 2008-06-18 09:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ca-certs_portable-find.patch (ca-certs_portable-find.patch,790 bytes, patch)
2008-06-11 23:46 UTC, Javier Villavicencio (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Hourihane 2008-06-10 14:25:09 UTC
When running update-ca-certificates I get this....

# update-ca-certificates 
Updating certificates in /root/gentoo/etc/ssl/certs....done.
Running hooks
in /etc/ca-certificates/update.d..../root/gentoo/usr/sbin/update-ca-certificates: line 96: run-parts: command not found
done.

Doing 'equery belongs run-parts' on an x86 box and I get....

[ Searching for file(s) run-parts in *... ]
sys-apps/debianutils-2.28.2 (/bin/run-parts)


Reproducible: Always
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-06-10 18:00:20 UTC
fixed in cvs.
Comment 2 Alexis Ballier gentoo-dev 2008-06-11 07:06:20 UTC
sorry but...
RDEPEND.badindev              2
   app-misc/ca-certificates/ca-certificates-20080514-r1.ebuild: ~sparc-fbsd(default-bsd/fbsd/6.2/sparc) ['sys-apps/debianutils']
   app-misc/ca-certificates/ca-certificates-20080514-r1.ebuild: ~x86-fbsd(default-bsd/fbsd/6.2/x86) ['sys-apps/debianutils']


this makes it uninstallable on all the bsd. There must be a better fix.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-06-11 07:33:37 UTC
aballier: just keyword debianutils on fbsd?
Comment 4 Alexis Ballier gentoo-dev 2008-06-11 07:35:35 UTC
(In reply to comment #3)
> aballier: just keyword debianutils on fbsd?
> 

09:28 <@aballier> loki_val: main point is, i think, we dont want *debian*utils on bsd ;)
[...]
09:31 <@The_Paya> loki_val: the preferred way in that case I think it would be to replace run-parts with something else.
09:31 <@The_Paya> kinda silly to depend on a package for just a command that runs scripts.
09:31 <@aballier> find ?


maybe something to investigate more
Comment 5 Dan Coats 2008-06-11 15:51:51 UTC
I agree this does not work for bsd at all. debianutils depends on coreutils which cant be used either.
Comment 6 Dan Coats 2008-06-11 15:56:47 UTC
I agree this does not work for bsd at all. debianutils depends on coreutils or mktemp which we don't need either provided by sys-freebsd/freebsd-ubin.
Comment 7 SpanKY gentoo-dev 2008-06-11 19:03:13 UTC
your analysis is incorrect.  ca-certificates needs mktemp ... the DEPEND there is to just ease upgrade paths.

you also shouldnt have keyworded the package in question in the first place if you didnt test it ... ca-certificates will not work if you dont have a "run-parts" binary.  since i doubt the bsd's provide it, it means you need debianutils installed.
Comment 8 Javier Villavicencio (RETIRED) gentoo-dev 2008-06-11 22:25:16 UTC
(In reply to comment #7)
> you also shouldnt have keyworded the package in question in the first place if
> you didnt test it ... ca-certificates will not work if you dont have a
> "run-parts" binary.  since i doubt the bsd's provide it, it means you need
> debianutils installed.
> 

In this case run-parts it's not used to /execute/ any scripts, it's used to save the typing of:
find ${DIR} -maxdepth 1 -perm -0700 -type f

It just *prints* (uses --test) the files that are executable on the hooksdir directory (which is empty in every gentoo I checked) and then the update script goes on to "eval ${them}" not even using run-parts again for that purpose.

This could be easily solved by replacing run-parts with that find command, depend on another package for just *that* feels kinda silly.
Comment 9 SpanKY gentoo-dev 2008-06-11 22:47:38 UTC
those commands are not equivalent.  if you want to post a correct patch, feel free.
Comment 10 Javier Villavicencio (RETIRED) gentoo-dev 2008-06-11 23:46:24 UTC
Created attachment 156445 [details, diff]
ca-certs_portable-find.patch

Here it is, nice and pretty, patch with the correct find -perm
Comment 11 SpanKY gentoo-dev 2008-06-12 00:37:03 UTC
Comment on attachment 156445 [details, diff]
ca-certs_portable-find.patch

please review the run-parts man page.  it isnt a simple find.  it includes filters in file names.
Comment 12 Javier Villavicencio (RETIRED) gentoo-dev 2008-06-12 01:56:18 UTC
(In reply to comment #11)
> (From update of attachment 156445 [details, diff] [edit])
> please review the run-parts man page.  it isnt a simple find.  it includes
> filters in file names.
> 

From the manpage:
       If  the  --lsbsysinit  option  is *not* given then the names must consist
       entirely of upper and lower case letters, digits, underscores,  hyphens
       and periods. However, the name must not begin with a period.

Adding \! -name "\.*" filters the names beginning with a period. Unless I'm missing some other character that may go into a script under /etc/ca-certificates/update.d ...
Comment 13 SpanKY gentoo-dev 2008-06-12 02:13:56 UTC
the breadth of valid characters that make up valid unix names is much more vast than what the manpage says run-parts looks for ... just look at your keyboard
Comment 14 Alexis Ballier gentoo-dev 2008-06-12 08:17:45 UTC
perhaps we could just be lazy and keyword debianutils if we could have installkernel and mkboot installed under kernel_linux ?
Comment 15 SpanKY gentoo-dev 2008-06-12 13:08:15 UTC
binding both of those binaries to kernel_linux sounds pretty reasonable, so if you want to commit that change, go for it
Comment 16 Alexis Ballier gentoo-dev 2008-06-16 21:22:18 UTC
(In reply to comment #15)
> binding both of those binaries to kernel_linux sounds pretty reasonable, so if
> you want to commit that change, go for it
> 

all good now, only sparc-fbsd left which i'll do as soon as the changes will have propagated to the rsync mirrors for the test box
Comment 17 SpanKY gentoo-dev 2008-06-18 09:40:37 UTC
thanks