Bug 225729 – java-utils-2.eclass: java-pkg_doso doesn't make files executable

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description James Le Cuirot 2008-06-10 10:51:59 UTC]

In java-utils-2.eclass, one would expect java-pkg_doso to make the installed files executable in the same way that dolib does. Currently this doesn't happen.

[Comment 1 James Le Cuirot 2008-06-10 14:51:45 UTC]

Created attachment 156247 [details, diff]
doso.patch

Actually I now notice that dolib defaults to 0644 as well. It's only dolib.so that uses 0755. The point still stands though.

I now also notice that LIBOPTIONS is ineffectively used to set the permissions. I am therefore attaching a fix.

[Comment 2 Petteri Räty (RETIRED) 2008-06-14 09:29:46 UTC]

(In reply to comment #1)
> 
> I now also notice that LIBOPTIONS is ineffectively used to set the permissions.
> I am therefore attaching a fix.
> 

Isn't the point of LIBOPTIONS to give ebuild writers the ability to control the options? Your patch could then in theory break ebuilds.

[Comment 3 James Le Cuirot 2008-06-14 10:24:19 UTC]

Yes but dolib.so forces 0755, regardless of LIBOPTIONS. dolib is there for other kinds of files. I can't think of any reason why you wouldn't want a .so file to be exectuble so java-pkg_doso should force it as well.

[Comment 4 Davide Pesavento (RETIRED) 2009-05-15 10:34:14 UTC]

java-pkg_doso() is basically reproducing dolib.so's behaviour, using a different destination directory. Since dolib.so sets LIBOPTIONS="-m0755", I think the proposed patch is correct.

[Comment 5 Bertrand Jacquin 2014-04-16 12:30:34 UTC]

(In reply to Davide Pesavento from comment #4)
> java-pkg_doso() is basically reproducing dolib.so's behaviour, using a
> different destination directory. Since dolib.so sets LIBOPTIONS="-m0755", I
> think the proposed patch is correct.

Any chances to get this merge ?

[Comment 6 James Le Cuirot 2015-05-02 20:24:21 UTC]

Merged.