net-nntp/hellanzb-0.13-r5 is missing optional dependency dev-python/pyopenssl for ssl/nntps connections. Attached files; new ebuild net-nntp/hellanzb-0.13-r6 diff between net-nntp/hellanzb-0.13-r5 and net-nntp/hellanzb-0.13-r6
Created attachment 155027 [details] new ebuild net-nntp/hellanzb-0.13-r6
Created attachment 155029 [details, diff] diff between net-nntp/hellanzb-0.13-r5 and net-nntp/hellanzb-0.13-r6
from what I read from the code, shouldn't it be the crypt useflag on twisted ?
(In reply to comment #3) > from what I read from the code, shouldn't it be the crypt useflag on twisted ? > Hi Alexis, As you can see in the code (from line 156 in NZBLeecher/__init__.py), if you select a server with nntps Hellanzb exits with warning "Unable to use SSL for server: pyOpenSSL is not installed". After installing pyopenssl Hellanzb functions as expected with nntps servers. It might work with the crypt useflag on twisted, but I haven't tested this. Is the current patch acceptable or do you prefer built_with_use? As far as I know Portage doesn't handle build_with_use automatically (yet?) and the user needs to manually reemerge twisted with crypt useflag enabled. IMHO a simple optional dependency on dev-python/pyopenssl is nicer. What do you think?
what I meant is: it uses twisted openssl support which is controlled via the crypt useflag on twisted; as it doesn't use pyopenssl directly I don't see the point in adding a dependency for an indirect dep. even if the error message is misleading. Of course your patch is much better than a built_with_use check; but my concerns were more about "is it really wise to start adding deps for optional dependencies of our dependencies ?"
(In reply to comment #5) > what I meant is: > it uses twisted openssl support which is controlled via the crypt useflag on > twisted; as it doesn't use pyopenssl directly I don't see the point in adding a > dependency for an indirect dep. even if the error message is misleading. > > Of course your patch is much better than a built_with_use check; but my > concerns were more about "is it really wise to start adding deps for optional > dependencies of our dependencies ?" > I have dev-python/twisted-8.1.0 without useflag crypt and Hellanzb works perfectly on nntps servers with only dev-python/pyopenssl. Maybe I don't understand you but I fail to see how this is an optional dependency of dependencies. I see this as a direct optional dependency of Hellanzb. The situation is that the current Hellanzb ebuild doesn't provide support for nntps servers. IMHO this is suboptimal. If you let me know what solution you prefer then I can submit a patch for it.
(In reply to comment #6) > > I have dev-python/twisted-8.1.0 without useflag crypt and Hellanzb works > perfectly on nntps servers with only dev-python/pyopenssl. Maybe I don't > understand you but I fail to see how this is an optional dependency of > dependencies. the crypt useflag on twisted should do the exact same thing: it wont change anything about twisted and it will use pyopenssl if it finds it. So you can install twisted with crypt useflag or without it and install pyopenssl later and it will be the exact same thing ;) > I see this as a direct optional dependency of Hellanzb. I'm still not convinced that it is, but you convinced me to add it to hellanzb in order to avoid people not understanding why hellanzb cannot connect to nntps servers or, at least, let them know that it can support it. Patch applied, thanks !
(In reply to comment #7) > Patch applied, thanks ! > Thanks!!
