Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 220739 - dev-util/astyle-1.22 stable request
Summary: dev-util/astyle-1.22 stable request
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Steve Arnold
Depends on:
Blocks: cflags
  Show dependency tree
Reported: 2008-05-07 11:28 UTC by Alex Buell
Modified: 2009-01-03 15:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

astyle-1.21.ebuild-cflags-cxx.patch (astyle-1.21.ebuild-cflags-cxx.patch,1.05 KB, patch)
2008-05-28 17:26 UTC, Tiago Cunha (RETIRED)
Details | Diff
Updated ebuild (works) (astyle-1.22.ebuild,2.47 KB, text/plain)
2008-09-28 18:00 UTC, Steve Arnold
astyle-1.22.ebuild-no-java.patch (astyle-1.22.ebuild.patch,1.08 KB, patch)
2008-09-29 19:46 UTC, Friedrich Oslage (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buell 2008-05-07 11:28:24 UTC
dev-util/astyle is masked on amd64, it may also need unmasking on other platforms as well. 

Reproducible: Always

Unmasking the ebuild solves the problem
Comment 1 Jan Kundrát (RETIRED) gentoo-dev 2008-05-07 12:59:10 UTC
Alex, please explain how is it masked, what problem are you facing here and then reopen this bug.
Comment 2 Alex Buell 2008-05-07 13:31:20 UTC
alexb ~ # eix astyle
* dev-util/astyle
     Available versions:  *1.15.3 ~1.15.3-r1 ~1.21 {debug libs}
     Description:         Artistic Style is a reindenter and reformatter of C++, C and Java source code

alexb ~ # emerge -pv astyle

These are the packages that would be merged, in order:

Calculating dependencies /
!!! All ebuilds that could satisfy "dev-util/astyle" have been masked.
!!! One of the following masked packages is required to complete your request:
- dev-util/astyle-1.21 (masked by: ~amd64 keyword)
- dev-util/astyle-1.15.3-r1 (masked by: ~amd64 keyword)
- dev-util/astyle-1.15.3 (masked by: missing keyword)

For more information, see MASKED PACKAGES section in the emerge man page or 
refer to the Gentoo Handbook.
Comment 3 Jan Kundrát (RETIRED) gentoo-dev 2008-05-07 13:40:16 UTC
The package isn't "masked", it's just available only in the stable branch. perhaps because its maintainers  haven't deemed it "stable" yet.
Comment 4 Steve Arnold gentoo-dev 2008-05-08 01:29:25 UTC
More like we forgot about it and nobody filed a bug until now...  :)

Let's make this an official stable request for astyle-1.21 and I'll add the 1.22 for testing.  Gentlemen (and ladies), start your engines...  Er...
Comment 5 Steve Arnold gentoo-dev 2008-05-17 00:59:53 UTC
CC'ing arches...
Comment 6 nixnut (RETIRED) gentoo-dev 2008-05-17 11:47:13 UTC
fails to find on ppc with ibm-jdk-bin-

 * Applying astyle-1.22-strip.patch ...                                   [ ok ]
 * Using bootclasspath /opt/ibm-jdk-bin-
 * Using JVM library path /opt/ibm-jdk-bin-
 * ERROR: dev-util/astyle-1.22 failed.
 * Call stack:  
 *     , line   49:  Called src_unpack
 *             environment, line 3773:  Called setup-jvm-opts
 *             environment, line 3709:  Called die
 * The specific snippet of code:
 *           die "Could not find native library";
 *  The die message:
 *   Could not find native library does exist, but it looks like paths changes compared to earlier jdk's
~ # locate
Comment 7 Tobias Klausmann gentoo-dev 2008-05-17 13:56:28 UTC
Stabled 1.21 on alpha.
Comment 8 Ferris McCormick (RETIRED) gentoo-dev 2008-05-18 13:42:26 UTC
Sparc NOT stable.  This package ignores my CFLAGS/CXXFLAGS from make.conf and uses
g++ -DNDEBUG -O3 -W -Wall -fno-rtti -fno-exceptions
This is bad on sparc.  -O3 is known to be a poor choice, and failing to use my -mcpu= choices is terrible.  Please see Bug 59506 for details.

For reference, I have:
CFLAGS="-O2 -mcpu=ultrasparc3 -pipe"
CXXFLAGS="-O2 -mcpu=ultrasparc3 -pipe"

Apparently the problem is someplace within the package configure process, because the ebuild does not touch CFLAGS at all.
Comment 9 Christian Faulhammer (RETIRED) gentoo-dev 2008-05-21 19:15:21 UTC
No respect for CFLAGS here either, but I will stable for x86 as no regression and the CFLAGS do no harm.
Comment 10 Markus Meier gentoo-dev 2008-05-24 13:39:19 UTC
amd64 stable
Comment 11 Tiago Cunha (RETIRED) gentoo-dev 2008-05-28 17:26:03 UTC
Created attachment 154597 [details, diff]

* Fix hardcoded CXX.
* Honour Gentoo CXXFLAGS (when USE="debug" supplied too).
* Use ${P} instead of ${PN}-${PV}.
Comment 12 Markus Rothe (RETIRED) gentoo-dev 2008-05-30 19:03:13 UTC
1.21 works ok, but I'm not going to mark it stable until a user requests so. there is no stable version yet.

1.22 does not compile on ppc64:

../src/astyle_main.cpp:56:17: error: jni.h: No such file or directory

so 1.22 is -ppc64 now.

[ I'm not even sure how this got keyworded.. there is no changelog entry for ppc64 ]
Comment 13 Matti Bickel (RETIRED) gentoo-dev 2008-09-07 01:02:39 UTC
@nerdboy: what about the patch from comment #11? I'm at a loss why USE="debug" doesn't disable -DNDEBUG for example.

And ppc suffers from the same error as ppc64:

g++ -DNDEBUG -DASTYLE_JNI -O3 -fpic -W -Wall -fno-rtti -fno-exceptions -I/usr/lib/jvm/java-6-sun- -I/usr/lib/jvm/java-6-sun- -c -o obj/astyle_main_sj.o ../src/astyle_main.cpp
../src/astyle_main.cpp:56:17: error: jni.h: No such file or directory
g++ -DNDEBUG -DASTYLE_JNI -O3 -fpic -W -Wall -fno-rtti -fno-exceptions -I/usr/lib/jvm/java-6-sun- -I/usr/lib/jvm/java-6-sun- -c -o obj/ASBeautifier_sj.o ../src/ASBeautifier.cpp
../src/astyle_main.cpp:62: error: expected constructor, destructor, or type conversion before '*' token
../src/astyle_main.cpp:63: error: 'jobject' does not name a type

This seems to be due to:
 # NOTE for java compiles the environment variable $JAVA_HOME must be set
 # example: export JAVA_HOME=/usr/lib/jvm/java-6-sun-
 ifndef JAVA_HOME
 #    JAVA_HOME = /usr/lib/jvm/java-1.5.0-sun-
    JAVA_HOME = /usr/lib/jvm/java-6-sun-

Seems paludis is not adding JAVA_HOME from the enviroment, due to:
>>> Starting pkg_setup
/var/tmp/paludis/dev-util-astyle-1.22/temp/loadsaveenv: line 4650: java-pkg-2_pkg_setup: command not found
Consequently, jni.h is not found on ppc and ppc64. Using portage, astyle-1.22 installs cleanly.

Except the CFLAGS ignorance, astyle-1.22 seems to install and work perfectly.

Leaving on ~ppc as long as the CFLAGS and paludis problems are not fixed.
Nerdboy, please say so if you want me to make the changes myself.
Comment 14 Steve Arnold gentoo-dev 2008-09-10 06:27:48 UTC
Sorry I've been a little busy, but don't stand on ceremony on my account.  In other words, feel free :)   Thanks...
Comment 15 Ferris McCormick (RETIRED) gentoo-dev 2008-09-10 13:06:27 UTC
Sparc stable for astyle-1.21.
Comment 16 Steve Arnold gentoo-dev 2008-09-28 17:58:58 UTC
Okay, I have a fixed-up version of 1.22 (I added the CFLAGS stuff in the attachment and fixed JAVA_HOME) but it won't commit as-is due to java-config deps on sparc and alpha.  This version works with gcc 4.3 but 1.21 does not (I looked at patching the latter, but there were just too many errors).

sparc/alpha: would you like to mask the java USE flag and keep the package?

ppc64: would you like to try keywording now?

I'll attach the updated ebuild (no additional patches required) and wait on the commit for now...
Comment 17 Steve Arnold gentoo-dev 2008-09-28 18:00:15 UTC
Created attachment 166700 [details]
Updated ebuild (works)
Comment 18 Friedrich Oslage (RETIRED) gentoo-dev 2008-09-29 19:46:50 UTC
Created attachment 166778 [details, diff]

(In reply to comment #16)
> Okay, I have a fixed-up version of 1.22 (I added the CFLAGS stuff in the
> attachment and fixed JAVA_HOME) but it won't commit as-is due to java-config
> deps on sparc and alpha.  This version works with gcc 4.3 but 1.21 does not (I
> looked at patching the latter, but there were just too many errors).
> sparc/alpha: would you like to mask the java USE flag and keep the package?

Java use flag is already masked globally on sparc. Why are you inheriting both, java-pkg-2 and java-pkg-opt-2? Afaik the first is for required java support and the later for optional.

I attached a patch, seems to be fine(at least with -java)
Comment 19 Steve Arnold gentoo-dev 2008-10-17 04:03:16 UTC
All the above issues should be fixed in 1.22 now, so I'd like to stablize that one and delete 1.21 (the older ones too, unless someone really needs one).  Thanks again for all the comments.
Comment 20 Ferris McCormick (RETIRED) gentoo-dev 2008-10-17 12:29:47 UTC
Sparc stable for astyle-1.22.
Comment 21 Matti Bickel (RETIRED) gentoo-dev 2008-10-18 02:59:27 UTC
Thanks for taking care, i quite neglected this bug...

But here's a ppc stable keyword anyway :)
Comment 22 Raúl Porcel (RETIRED) gentoo-dev 2008-10-18 15:20:07 UTC
alpha/x86 stable
Comment 23 Steve Arnold gentoo-dev 2008-10-18 19:15:16 UTC
One more try for amd64 please?  And would ppc64 like to try keywording now?  I notice there's at least an IBM JDK for ppc64, and in theory it should work...  Thanks in advance...
Comment 24 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2008-10-20 13:17:31 UTC
USE="libs java" on amd64 results in prestripped files:

>>> Completed installing astyle-1.22 into /var/tmp/portage/dev-util/astyle-1.22/image/

 * QA Notice: Pre-stripped files found:
 * /var/tmp/portage/dev-util/astyle-1.22/image/usr/lib64/
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment
* checking 13 files for package collisions
>>> Merging dev-util/astyle-1.22 to /
Comment 25 Steve Arnold gentoo-dev 2008-11-11 02:41:59 UTC
Forget one; try it now (plus sync time)...
Comment 26 Steve Arnold gentoo-dev 2008-11-14 02:56:21 UTC
That should say "I forgot one" but now the last -s is gone, so please try it one more time...
Comment 27 Markus Meier gentoo-dev 2008-11-22 23:30:17 UTC
amd64 stable
Comment 28 Brent Baude (RETIRED) gentoo-dev 2008-12-02 22:49:09 UTC
Comment 29 Alex Buell 2008-12-18 12:45:09 UTC
If you've all finished, feel free to close this :-D